Repository navigation
fix(devvit): align leaderboard capability reporting - #69
Conversation
|
@codex review Please focus on whether the Devvit target now consistently distinguishes unsupported native platform leaderboards from the server-only verified leaderboard provider, and whether generated starters, target metadata, tests, docs, and release metadata remain aligned. |
|
@coderabbitai review Please review the Devvit leaderboard capability boundary, disabled generic client score path, generated starter parity, smoke coverage, and Sampo release impact. |
🧩 Analysis chain🏁 Script executed: #!/bin/bash
set -euo pipefail
gh pr view 69 --repo imjlk/mpgd-kit --json title,body,files,additions,deletions,commits -q '.'
echo "----DIFF----"
gh pr diff 69 --repo imjlk/mpgd-kit > /tmp/pr69.diff
wc -l /tmp/pr69.diff
echo "----FILES----"
gh pr view 69 --repo imjlk/mpgd-kit --json files -q '.files[].path'Length of output: 3832 🏁 Script executed: #!/bin/bash
set -euo pipefail
cat /tmp/pr69.diffLength of output: 28023 🏁 Script executed: #!/bin/bash
set -euo pipefail
sed -n '1,40p' apps/target-devvit/src/server/index.ts
echo "---"
rg -n "redis\.|optionalObjectPayload|createBridgeError|errorMessage" apps/target-devvit/src/server/index.ts
echo "---imports---"
rg -n "^import" apps/target-devvit/src/server/index.tsLength of output: 3185 🏁 Script executed: #!/bin/bash
set -euo pipefail
echo "== leaderboard.open handling =="
rg -n "leaderboard" adapters/devvit/src/index.ts
echo "== targets.json leaderboard section context =="
sed -n '200,250p' packages/target-config/targets.json
echo "== adapter-effective-config full context around edit =="
sed -n '190,270p' tools/smoke/adapter-effective-config.ts
echo "== check other targets (ait, web) for nativeLeaderboard consistency =="
rg -n "nativeLeaderboard|leaderboard" packages/target-config/targets.json
echo "== check schema for leaderboard.native field / defaultLeaderboardId optionality =="
fd -a "schema" packages/target-config | head -20Length of output: 5342 🏁 Script executed: #!/bin/bash
set -euo pipefail
echo "== wrapGateway impl - leaderboard section =="
rg -n "wrapGateway|leaderboard" tools/smoke/adapter-effective-config.ts | head -40
echo "---"
rg -n "function wrapGateway" -A 60 tools/smoke/adapter-effective-config.ts | sed -n '1,80p'Length of output: 3429 This confirms
One minor observation (not a blocker): Overall this looks solid and internally consistent — nice work aligning the capability boundary end-to-end across the adapter, server, generated starter, docs, smoke tests, and release metadata. ✅ Action performedReview finished.
|
|
Warning Review limit reached
Next review available in: 36 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughDevvit and Reddit targets no longer advertise native leaderboards or accept generic client score submissions. Server bridges retain storage functionality while verified server-side completion and snapshot flows are documented and validated. ChangesDevvit leaderboard disablement
Estimated code review effort: 3 (Moderate) | ~25 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0ee0108084
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review Please re-review the updated head |
|
Codex Review: Didn't find any major issues. Hooray! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Summary
Validation
mise exec -- pnpm testpnpm checkpnpm graph:preflightpnpm validate:target-configpnpm validate:effective-configpnpm validate:targetspnpm smoke:target-configpnpm smoke:effective-configpnpm smoke:adapter-effective-configpnpm validate:starter-workflowpnpm build:devvitRelease
Includes a patch changeset for
@mpgd/adapter-devvit,@mpgd/target-config,@mpgd/cli, and@mpgd/create-game.Review
OpenCodeReview workspace scan: 0 comments. Commit scan: 0 High/Medium comments; one documentation-comment nit was not adopted because the generated README and verified leaderboard guide already explain the boundary and supported integration path.
Summary by CodeRabbit
Bug Fixes
Documentation
Tests