Repository navigation
Share Microsoft Store PWA release checks - #81
Conversation
|
Warning Review limit reached
Next review available in: 33 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (5)
📝 WalkthroughWalkthroughAdds Microsoft Store PWA browser E2E helpers, shared release-evidence validation, cache-transition assertions, smoke coverage, public exports, documentation, and source-to-built manifest contract checks. ChangesMicrosoft Store PWA validation and E2E flow
Estimated code review effort: 4 (Complex) | ~45 minutes Sequence Diagram(s)sequenceDiagram
participant Browser
participant CLIHelpers
participant CacheStorage
Browser->>CLIHelpers: read release evidence
CLIHelpers->>Browser: request service-worker update
Browser->>CLIHelpers: inspect activated caches
CLIHelpers->>CacheStorage: read release B index and cache keys
CacheStorage-->>CLIHelpers: transition observations
CLIHelpers-->>Browser: validated transition evidence
Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (1)
packages/cli/src/microsoft-store-pwa-e2e.ts (1)
106-112: 🎯 Functional Correctness | 🔵 Trivial | ⚡ Quick winCorrect
getRegistrationparameter typing and usage.The parameter for
ServiceWorkerContainer.getRegistration()is an optionalclientURL, not ascope. Supplying no arguments guarantees returning the registration that controls the current document exactly, mitigating the risk of mismatch from'./'relative resolution.♻️ Proposed refactor
- getRegistration(scope: string): Promise<{ + getRegistration(clientURL?: string): Promise<{ update(): Promise<unknown>; } | undefined>; }; }; }; - const registration = await browser.navigator.serviceWorker.getRegistration('./'); + const registration = await browser.navigator.serviceWorker.getRegistration();🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@packages/cli/src/microsoft-store-pwa-e2e.ts` around lines 106 - 112, Update the local ServiceWorkerContainer declaration around getRegistration so its parameter is optional and represents clientURL rather than a required scope, then call getRegistration without arguments in the registration lookup. Preserve the existing registration update flow.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/cli/src/microsoft-store-pwa-e2e.ts`:
- Around line 155-171: In the cache inspection flow, capture the result of
browser.caches.keys() before calling browser.caches.open for scopedCacheNames.b.
Update the return in the surrounding function to reuse that pre-open cache-name
snapshot, while preserving the existing cache match and missing-index
validation.
- Around line 356-358: Update the protocol validation near the service worker
registration scope check to accept file: alongside http: and https:. Keep
rejecting all other protocols and preserve the existing error behavior for
unsupported values.
---
Nitpick comments:
In `@packages/cli/src/microsoft-store-pwa-e2e.ts`:
- Around line 106-112: Update the local ServiceWorkerContainer declaration
around getRegistration so its parameter is optional and represents clientURL
rather than a required scope, then call getRegistration without arguments in the
registration lookup. Preserve the existing registration update flow.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 3486bee1-6c76-43c7-afb2-6db9f63de571
📒 Files selected for processing (9)
.sampo/changesets/microsoft-store-pwa-browser-e2e.mddocs/GAMEPLAY_E2E.mdpackage.jsonpackages/cli/src/index.tspackages/cli/src/microsoft-store-pwa-e2e.tstools/smoke/cli-microsoft-store-pwa-e2e.tstools/smoke/verify-target-artifacts.test.tstools/smoke/verify-target-artifacts.tstools/target/microsoft-store-pwa.ts
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cf70759d01
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@coderabbitai review\n\nAddressed the valid cache-observation and getRegistration findings in cec4329. The file: suggestion was intentionally declined with rationale in its thread. Please re-review the updated commit. |
|
Codex Review: Didn't find any major issues. Can't wait for the next one! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Summary
@mpgd/cliWhy
Game harnesses were duplicating cache-name resolution and A→B update assertions, while artifact smoke only checked manifest shape. That allowed drift between generated release evidence, runtime playtests, and source manifest metadata.
Impact
Games keep Playwright, server switching, and game-specific selectors locally, while importing the shared PWA contract and transition assertions from
@mpgd/cli. Production target smoke now rejects non-icon manifest metadata drift.Review
OpenCodeReview was run against the final change. Its valid findings were addressed by restoring the producer's strict 40-character lowercase Git SHA contract, trimming validated strings, and correcting the cache-name smoke expectation.
Validation
pnpm checkpnpm testttsxMicrosoft Store PWA browser helper smokepnpm smoke:target microsoft-storeSummary by CodeRabbit