Repository navigation
feat: add Verse8 Agent8 services - #86
Conversation
|
@codex review @coderabbitai review |
|
✅ Action performedReview finished.
|
|
Warning Review limit reached
Next review available in: 45 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (6)
📝 WalkthroughWalkthroughAdds opt-in Verse8 Agent8 cloud storage, a server-verified leaderboard provider with authenticated participant scoping and opaque pagination, gateway integration, tests, exports, documentation, and release metadata. ChangesVerse8 Agent8 integration
Estimated code review effort: 4 (Complex) | ~60 minutes Sequence Diagram(s)sequenceDiagram
participant GameClient
participant Verse8PlatformGateway
participant Agent8StorageService
participant Agent8StateContext
GameClient->>Verse8PlatformGateway: save/load cloud state
Verse8PlatformGateway->>Agent8StorageService: delegate storage operation
Agent8StorageService->>Agent8StateContext: read/update authenticated user state
Agent8StateContext-->>Agent8StorageService: stored state
Agent8StorageService-->>Verse8PlatformGateway: storage result
sequenceDiagram
participant AuthenticatedClient
participant LeaderboardBoundary
participant GameVerifier
participant VerifiedLeaderboardProvider
AuthenticatedClient->>LeaderboardBoundary: submit attempt
LeaderboardBoundary->>GameVerifier: verify submission
GameVerifier-->>LeaderboardBoundary: verified attempt or rejection
LeaderboardBoundary->>VerifiedLeaderboardProvider: record verified attempt
VerifiedLeaderboardProvider-->>AuthenticatedClient: submission or snapshot result
Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1cf7654af2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
adapters/verse8/src/agent8-services.test.ts (1)
73-157: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winConsider adding a test for the orphaned-attempt-entry recovery path.
recordVerifiedAttemptinadapters/verse8/src/agent8-services.ts(lines 319-329) has specific recovery logic for when anentrieswrite succeeded but the correspondingattemptsdecision write never completed (e.g. a crash between the two calls). This is a non-obvious, implementation-specific correctness guarantee that the imported conformance suite is unlikely to cover, since it depends on the two-collection storage model of this specific provider. A test that manually seedsfixture's entries collection (bypassingattempts) and then re-submits the same attempt would validate this recovery path directly.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@adapters/verse8/src/agent8-services.test.ts` around lines 73 - 157, Add a focused test near the existing provider tests that seeds the fixture’s entries collection for an attempt without creating its corresponding attempts decision, then re-submits that same attempt through recordVerifiedAttempt. Assert the orphaned entry is recovered correctly and the resulting state matches the normal successful recording path, using the fixture APIs and symbols exposed by createAgent8Context.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@adapters/verse8/src/agent8-services.test.ts`:
- Around line 73-157: Add a focused test near the existing provider tests that
seeds the fixture’s entries collection for an attempt without creating its
corresponding attempts decision, then re-submits that same attempt through
recordVerifiedAttempt. Assert the orphaned entry is recovered correctly and the
resulting state matches the normal successful recording path, using the fixture
APIs and symbols exposed by createAgent8Context.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: be4fac93-1bcb-461d-8f4e-dc59700aee01
📒 Files selected for processing (12)
.sampo/changesets/verse8-agent8-services.mdREADME.mdadapters/verse8/src/agent8-services.test.tsadapters/verse8/src/agent8-services.tsadapters/verse8/src/agent8.tsadapters/verse8/src/index.test.tsadapters/verse8/src/index.tsadapters/verse8/test/agent8-dist-import.mjsdocs/VERSE8_AGENT8_SERVICES.mdpackages/cli/templates/phaser-game/README.mdpackages/target-config/targets.jsontools/smoke/effective-target-config.ts
|
Addressed all current review feedback in 0798bfc and a4d4eaf:
@codex review @coderabbitai review |
|
✅ Action performedReview finished.
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a4d4eafade
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Addressed the latest Codex review in 609966c:
@codex review @coderabbitai review |
|
✅ Action performedReview finished.
|
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/VERSE8_AGENT8_SERVICES.md`:
- Around line 81-84: Update the Verse8 example’s cloud-save gating to call the
gateway capabilities API and read the cloudSave property from await
gateway.getCapabilities(). Remove the unsupported gateway.features reference
while preserving the existing conditional behavior.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 56b87932-fa4c-4691-8f6c-72f9c732768f
📒 Files selected for processing (6)
.sampo/changesets/verse8-agent8-services.mdREADME.mdadapters/verse8/src/agent8-services.test.tsadapters/verse8/src/agent8-services.tsdocs/VERSE8_AGENT8_SERVICES.mdtools/smoke/effective-target-config.ts
🚧 Files skipped from review as they are similar to previous changes (3)
- .sampo/changesets/verse8-agent8-services.md
- tools/smoke/effective-target-config.ts
- adapters/verse8/src/agent8-services.ts
|
Codex Review: Didn't find any major issues. Can't wait for the next one! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Addressed the CodeRabbit documentation finding in b79c78a:
@codex review @coderabbitai review |
|
✅ Action performedReview finished.
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b79c78acae
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Addressed the latest Codex security review in ecda1ea:
@codex review @coderabbitai review |
|
✅ Action performedReview finished.
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ecda1ea96f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review @coderabbitai review |
|
✅ Action performedReview finished.
|
|
Codex Review: Didn't find any major issues. 🎉 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Summary
startAfterSafety boundaries
PlatformGateway.leaderboardunavailableValidation
pnpm checkpnpm build:packagespnpm test:preparedpnpm build:verse8pnpm smoke:target verse8Changeset
Adds minor changesets for
@mpgd/adapter-verse8and@mpgd/cli.Summary by CodeRabbit
New Features
Documentation
Tests