transpile: Refactor and improve address-of handling - #1982
Draft
Rua wants to merge 12 commits into
Draft
Conversation
Rua
force-pushed
the
array-decay-refactor
branch
2 times, most recently
from
August 24, 2026 08:24
0f13150 to
70bcccb
Compare
Rua
force-pushed
the
array-decay-refactor
branch
5 times, most recently
from
August 25, 2026 14:38
39bc23c to
938ab27
Compare
Rua
force-pushed
the
array-decay-refactor
branch
6 times, most recently
from
August 26, 2026 10:02
2f12e6b to
e850d52
Compare
Rua
force-pushed
the
array-decay-refactor
branch
from
September 2, 2026 07:49
e850d52 to
01a469e
Compare
Rua
marked this pull request as ready for review
September 2, 2026 07:49
Rua
force-pushed
the
array-decay-refactor
branch
3 times, most recently
from
September 2, 2026 16:11
0f48954 to
666a7b5
Compare
Rua
force-pushed
the
array-decay-refactor
branch
from
September 3, 2026 18:21
666a7b5 to
9fe69bc
Compare
Rua
force-pushed
the
array-decay-refactor
branch
from
September 3, 2026 18:28
9fe69bc to
69e9791
Compare
Rua
marked this pull request as draft
September 3, 2026 18:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make_cast#1984This PR does a few things that more or less depend on each other:
ptr::from_ref, which is now available in the currently used nightly. It's still unstable there, but it's stable in Rust 2024 so it shouldn't be much of an issue to use it?constcontext, only do an immutable borrow first if the edition isn't 2024. The feature that allowed mutable borrows inconstcontext was stabilised before the 2024 edition.convert_address_of_commonhandles casting after the borrow operation. It now deep-compares the pointee types and casts only if actually needed.decay_ref. It was a bit of a deadweight anyway since address-of was changed to use raw borrows. Usingfrom_refmakes it completely unnecessary.