transpile: Don't pass ExprContext to most decls - #1990
Draft
Rua wants to merge 5 commits into
Draft
Conversation
Rua
marked this pull request as draft
September 2, 2026 13:27
Rua
force-pushed
the
exprcontext-decl
branch
2 times, most recently
from
September 4, 2026 13:53
2f57dba to
9f13e26
Compare
Rua
force-pushed
the
exprcontext-decl
branch
from
September 4, 2026 15:35
9f13e26 to
f2c82a3
Compare
Rua
marked this pull request as ready for review
September 4, 2026 15:35
Rua
marked this pull request as draft
September 4, 2026 16:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generally speaking, decls don't care about the context they're in, so I don't think there's a point in passing it. The only exception I can see is if a macro expands to a statement expression that declares variables. In that case the variables are being declared inside a
constcontext and their initializers may not be translatable.