fix(wizard): remove [WebUI]/[Terminal] prefixes from pack chooser (do not merge yet) - #93
Merged
Merged
Conversation
Roy: 'remove the ugly [WebUI] and [Terminal] stuff from the initial
lowkey wizard'.
- Drop the in_list detection loop and the branching item construction;
the pack list now just shows 'name — description' with the existing
'(experimental)' suffix intact.
- Simplify the post-choose parse: PACK_NAME='${pack_choice%% —*}' plus
a trailing-space trim (no more bracket-strip needed).
Diff: +2 / -11. bash -n install.sh: OK.
Roy: 'also make the cognito login default false for kirocrew pack
choice (same PR)'.
configure_webui_auth() calls confirm with default_yes for the
'Protect ${pack_name} WebUI with Cognito login?' question. Switch to
default_no so the user has to opt in. Cognito adds a companion
us-east-1 stack, a Lambda@Edge zip build, and 5-15 min of extra
CloudFront propagation; making it opt-in matches the friction it adds.
--webui-no-auth flag and unattended (AUTO_YES) skip paths unchanged.
Roy: 'in the final output of the install, the result should not have | content | in the middle of the output box in ascii. the output box should just be floor and top, since links are harder to copy between the || lines. (same PR)' The rounded border on the next-steps gum style adds vertical rails (│ ... │) that interfere with triple-click select and copy of the dashboard URL and shell commands inside the box. Drop --border rounded and --border-foreground on the next_block style call. Padding and margin stay, so the block still stands out visually via foreground color and spacing. The info_block above was already borderless; this brings next_block in line. Diff: +3 / -2. bash -n install.sh: OK.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Roy: "remove the ugly [WebUI] and [Terminal] stuff from the initial lowkey wizard".
Old chooser
New chooser
Changes
in_list/webui_packsdetection loop; item is now"${pname} — ${PACK_DESCS[$i]}"with the existing(experimental)suffix intact.PACK_NAME="${pack_choice%% —*}"plus a trailing-space trim (no more bracket-strip needed).Verified
bash -n install.sh: OKNot merging per Aug 22 20:34 rule.