Repository navigation
Sjip 1613/make npm installs reproducible - #1032
Merged
Merged
Conversation
Both quality workflows triggered only on pull_request to main while PRs target dev, so neither has been running at all. They now run on dev as well. tests.yml installs with npm ci instead of npm i, so lockfile drift fails a PR rather than a Netlify deploy. Both workflows pin node through setup-node and node-version-file. actions/checkout aligned to v4 everywhere; v3 runs the deprecated node 16 runtime.
Adds .nvmrc (22.23.2), .npmrc with engine-strict=true, and an engines field allowing node 22-23 and npm 10-11. A lockfile is a function of the npm that writes it, so an unpinned toolchain makes drift inevitable. This is the third recurrence; see SJIP-1580 and SJIP-1520. Follow-up: remove NODE_VERSION from the Netlify dashboard so .nvmrc is the single source of truth.
npm ci failed on dev as of c60c830 with "Missing: yaml@2.9.1 from lock file". Regenerated with npm install: +41 lines, no version changes, nothing removed. npm ci verified passing afterwards.
✅ Deploy Preview for include-qa ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Project Coverage and TestCoverage summary Test Suites: 6 failed, 6 total |
Coverage report
Test suite run success0 tests passing in 0 suite. Report generated by 🧪jest coverage report action from a558a52 |
The extract_parts step used git log --pretty=%B which feeds the whole commit message into the regex. Capture group 5 then swallowed the body and $GITHUB_OUTPUT rejected the multi-line value with "Invalid format". Switches to %s so only the subject line is parsed. Same fix already applied in kf-portal-ui under SKFP-1619.
AltefrohneGaelle
approved these changes
Sep 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generating Content ....