Skip to content

chore: override d3-color to ^3.1.0 and fix issues introduced in previous depbot PRs - #897

Open
jdstrand wants to merge 5 commits into
masterfrom
jdstrand/update-d3-color
Open

chore: override d3-color to ^3.1.0 and fix issues introduced in previous depbot PRs#897
jdstrand wants to merge 5 commits into
masterfrom
jdstrand/update-d3-color

Conversation

@jdstrand

@jdstrand jdstrand commented Aug 31, 2026

Copy link
Copy Markdown
Collaborator

This updates d3-color for transitive dependencies to also use 3.1.0, fixing an unimportant dependabot alert. Instead of dismissing the alert, move forward so we can continue to maintain this repo. This required a change to giraffe/jest.config.js due to a change in d3-color 3.1.0

In testing this, it was discovered the PR #886 broke CI since it needed node >=18, but we only had 16 (for some reason, build wasn't required to pass and was missed). In working through that, it was discovered that node-sass is unsupported and needs node 18 or earlier, which is EOL. As we move forward with dependabot updates, dependencies will require node 20 or newer more and more, so use the supported sass and update to cimg/node:24.20 (current lts; we don't use lts yet since it will move to 26 at some point, potentially breaking builds).

webpack v4 uses MD4 which is removed from openssl 3. Newer versions of node (after 14) use openssl 3, so pass NODE_OPTIONS=--openssl-legacy-provider to storybook (which calls webpack) until we can upgrade.

Run yarn run build-storybook in CI.

@jdstrand
jdstrand requested review from a team and mavarius as code owners August 31, 2026 16:01
@jdstrand
jdstrand force-pushed the jdstrand/update-d3-color branch from 2c5b220 to 94fe2c7 Compare August 31, 2026 16:08
eatondustin1
eatondustin1 previously approved these changes Aug 31, 2026
@jdstrand
jdstrand force-pushed the jdstrand/update-d3-color branch 2 times, most recently from b06fbfa to e3829be Compare August 31, 2026 16:41
node-sass is unsupported and needs node 18 or earlier, which is EOL.
Some current dependencies require node 20 or newer, so use the supported
'sass' and update to 'cimg/node:24.20' (current 'lts'; we don't use
'lts' yet since it will move to '26' at some point, potentially breaking
builds).
@jdstrand
jdstrand force-pushed the jdstrand/update-d3-color branch 2 times, most recently from c1bab60 to e268ed7 Compare August 31, 2026 18:11
webpack v4 uses MD4 which is removed from openssl 3. node 24 uses
openssl 3, so pass NODE_OPTIONS=--openssl-legacy-provider to storybook
until we can upgrade.
@jdstrand
jdstrand force-pushed the jdstrand/update-d3-color branch from e268ed7 to 9db78bd Compare August 31, 2026 18:18
@jdstrand jdstrand changed the title chore: override d3-color to ^3.1.0 chore: override d3-color to ^3.1.0 and fix issues introduced in previous depbot PRs Aug 31, 2026
@jdstrand
jdstrand force-pushed the jdstrand/update-d3-color branch from 9db78bd to ac7cd36 Compare August 31, 2026 18:41
@jdstrand

Copy link
Copy Markdown
Collaborator Author

for some reason, build wasn't required to pass and was missed
I updated the giraffe circleci setting to require build to pass. Hopefully that will help going forward.

@jdstrand

Copy link
Copy Markdown
Collaborator Author

@eatondustin1 - hey, can you re-review? I had to make a number of additional changes after realizing the repo wasn't passing build for a while. Thanks!

@jdstrand
jdstrand requested a review from eatondustin1 August 31, 2026 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants