chore: override d3-color to ^3.1.0 and fix issues introduced in previous depbot PRs - #897
Open
jdstrand wants to merge 5 commits into
Open
chore: override d3-color to ^3.1.0 and fix issues introduced in previous depbot PRs#897jdstrand wants to merge 5 commits into
jdstrand wants to merge 5 commits into
Conversation
jdstrand
force-pushed
the
jdstrand/update-d3-color
branch
from
August 31, 2026 16:08
2c5b220 to
94fe2c7
Compare
eatondustin1
previously approved these changes
Aug 31, 2026
jdstrand
force-pushed
the
jdstrand/update-d3-color
branch
2 times, most recently
from
August 31, 2026 16:41
b06fbfa to
e3829be
Compare
node-sass is unsupported and needs node 18 or earlier, which is EOL. Some current dependencies require node 20 or newer, so use the supported 'sass' and update to 'cimg/node:24.20' (current 'lts'; we don't use 'lts' yet since it will move to '26' at some point, potentially breaking builds).
jdstrand
force-pushed
the
jdstrand/update-d3-color
branch
2 times, most recently
from
August 31, 2026 18:11
c1bab60 to
e268ed7
Compare
webpack v4 uses MD4 which is removed from openssl 3. node 24 uses openssl 3, so pass NODE_OPTIONS=--openssl-legacy-provider to storybook until we can upgrade.
jdstrand
force-pushed
the
jdstrand/update-d3-color
branch
from
August 31, 2026 18:18
e268ed7 to
9db78bd
Compare
jdstrand
force-pushed
the
jdstrand/update-d3-color
branch
from
August 31, 2026 18:41
9db78bd to
ac7cd36
Compare
Collaborator
Author
|
Collaborator
Author
|
@eatondustin1 - hey, can you re-review? I had to make a number of additional changes after realizing the repo wasn't passing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates
d3-colorfor transitive dependencies to also use 3.1.0, fixing an unimportant dependabot alert. Instead of dismissing the alert, move forward so we can continue to maintain this repo. This required a change togiraffe/jest.config.jsdue to a change ind3-color3.1.0In testing this, it was discovered the PR #886 broke CI since it needed node >=18, but we only had 16 (for some reason,
buildwasn't required to pass and was missed). In working through that, it was discovered thatnode-sassis unsupported and needs node 18 or earlier, which is EOL. As we move forward with dependabot updates, dependencies will require node 20 or newer more and more, so use the supportedsassand update tocimg/node:24.20(currentlts; we don't useltsyet since it will move to26at some point, potentially breaking builds).webpackv4 uses MD4 which is removed from openssl 3. Newer versions of node (after 14) use openssl 3, so passNODE_OPTIONS=--openssl-legacy-providerto storybook (which calls webpack) until we can upgrade.Run
yarn run build-storybookin CI.