Otlp exporter config#512
Open
arjun-rajappa wants to merge 4 commits into
Open
Conversation
- Add OTLP config block to Config#initialize with defaults (disabled) - Support config precedence: YAML > env vars > agent discovery > defaults - Add read_otlp_config_from_agent to apply agent-pushed OTLP settings - Replace hardcoded INSTANA_OTLP_ENABLED env-var branch in HostAgentReportingObserver with initialize_otlp_exporter driven by ::Instana.config[:otlp] - Remove debug info log of converted spans before OTLP export - Add tests for config and observer initialization Signed-off-by: Arjun Rajappa <arjun.rajappa@ibm.com>
Signed-off-by: Arjun Rajappa <arjun.rajappa@ibm.com>
Signed-off-by: Arjun Rajappa <arjun.rajappa@ibm.com>
Signed-off-by: Arjun Rajappa <arjun.rajappa@ibm.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the hardcoded INSTANA_OTLP_ENABLED env-var check with a proper config-driven setup. OTLP settings are now resolved through the standard Instana config system with precedence: YAML → env vars → agent discovery → defaults.
Change
Config - add :otlp config block (default: disabled); support YAML, env var, and agent-push config sources
HostAgentReportingObserver — replace inline exporter construction with initialize_otlp_exporter driven by ::Instana.config[:otlp]; remove stray debug log
Tests - add config_test.rb and expand observer tests to cover OTLP init paths