Repository navigation
ci: dependency review and Renovate config validation #302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| # Copyright (C) 2026 Intel Corporation | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| name: dependency-review | ||
|
|
||
| # Judges only the dependencies a PR changes (pip-audit.yml audits the locks daily). | ||
| # Path-filtered, so it must stay out of the required checks. | ||
| on: | ||
| pull_request: | ||
| paths: | ||
| - 'dokimi/requirements*.txt' | ||
| - 'dokimi/pyproject.toml' | ||
| - '.github/workflows/**' | ||
| - '.github/actions/**' | ||
|
|
||
| permissions: | ||
| contents: read | ||
|
|
||
| concurrency: | ||
| group: ${{ github.workflow }}-${{ github.event.pull_request.number }} | ||
| cancel-in-progress: true | ||
|
|
||
| jobs: | ||
| dependency-review: | ||
| name: Dependency review | ||
| # A short job: ubuntu-latest, as for the other short jobs (see ci.yml). | ||
| runs-on: ubuntu-latest | ||
| timeout-minutes: 10 | ||
| steps: | ||
| - uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1 | ||
| with: | ||
| persist-credentials: false | ||
| - uses: actions/dependency-review-action@a1d282b36b6f3519aa1f3fc636f609c47dddb294 # v5.0.0 | ||
| with: | ||
| fail-on-severity: high | ||
| # The filelock advisories SECURITY.md documents; tests/test_advisory_lists.py | ||
| # keeps them in sync with pip-audit.yml and dokimi/osv-scanner.toml. | ||
| allow-ghsas: GHSA-567q-5qvw-pf92,GHSA-6627-m3xw-93mp,GHSA-69hj-f68j-2879,GHSA-8mx5-7m5m-r77g,GHSA-9c4x-gm8v-wgc4,GHSA-9j6q-wvj5-jgjg,GHSA-9vhv-jxww-xfm5,GHSA-cwqr-hh33-gh44,GHSA-fq56-3cx3-fjxp,GHSA-j8f7-rjxc-mr56,GHSA-m462-7rxw-wvpg,GHSA-rfpc-qcw5-3pc4,GHSA-v4x8-3wr5-3wq8 | ||
| # The summary only: a PR comment would need pull-requests: write, | ||
| # which a fork PR's token does not have. | ||
| comment-summary-in-pr: never | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| # Copyright (C) 2026 Intel Corporation | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| name: renovate-validation | ||
|
|
||
| # Renovate silently stops opening PRs on a config it cannot parse; | ||
| # --strict also fails on deprecated options. | ||
| on: | ||
| push: | ||
| branches: [ main ] | ||
| paths: &renovate-paths | ||
| - '.github/renovate.json5' | ||
| - '.github/workflows/renovate-validation.yml' | ||
| pull_request: | ||
| paths: *renovate-paths | ||
| workflow_dispatch: | ||
|
|
||
| permissions: | ||
| contents: read | ||
|
|
||
| concurrency: | ||
| group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.run_id }} | ||
| cancel-in-progress: ${{ github.event_name == 'pull_request' }} | ||
|
|
||
| jobs: | ||
| validate: | ||
| name: Renovate config | ||
| # A short job: ubuntu-latest, as for the other short jobs (see ci.yml). | ||
| runs-on: ubuntu-latest | ||
| timeout-minutes: 10 | ||
| steps: | ||
| - uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1 | ||
| with: | ||
| persist-credentials: false | ||
| - uses: suzuki-shunsuke/github-action-renovate-config-validator@1e1604219a6b38ae9a10aff42a28a3656322c31a # v2.4.1 | ||
| with: | ||
| config_file_path: .github/renovate.json5 | ||
| strict: 'true' | ||
| # The action installs the latest validator from npm unless pinned; | ||
| # the custom manager in renovate.json5 bumps this line. | ||
| validator_version: '44.198.0' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: no
timeout-minutes, while the other workflows set one (for example agent-quality.yml and conda-forge.yml: 15). A hung job would run for 6 hours. Addtimeout-minutes: 10. The same applies to renovate-validation.yml.Suggestion:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in 9792e16:
timeout-minutes: 10on both new jobs.