"Download Flame Graph" option does not work

[prashantbytesyntax]

Browser : Chome v135

Repro Steps :

1. Go to gProfiler Performance Studio UI
2. Select any available profilers
3. Click on options menu on top right
4. Click ""Download Flame Graph"

Actual : Flame graph svg file is not getting downloaded

Expected : Flame graph svg file should be downloaded

[mlim19]

@prashantbytesyntax, the fix is now merged with our verification. Please check out and close the issue after you verify it.

[jwintel]

@prashantbytesyntax Thank you for the review. I've merged the workaround, please close the issue if the fix is verified.

[prashantbytesyntax]

@mlim19 here are the workaround steps after the fix :

1. Go to gProfiler Performance Studio UI
2. Select any available profilers
3. Select Chrome developer tools
4. Search for "Download"
5. right click "Copy Link Address"
6. Paste in new tab

Console error :
Mixed Content: The site at 'https://gprofiler.domain.com/' was loaded over a secure connection, but the file at 'https://gprofiler.domain.com/api/flamegraph/download_svg?my_long_query_param_url' was redirected through an insecure connection. This file should be served over HTTPS. See https://blog.chromium.org/2020/02/protecting-users-from-insecure.html for more details.

Also noticed the timeout error when samples are more than 1 million

[gmunoz]

FYI, this looks like an erroneous trailing slash, "/", in the code base that won't match the backend route. That is, /api/flamegraph/download_svg/ as opposed to /api/flamegraph/download_svg.

I understand the need to also correctly negotiate a secure connection. But the two are separate concerns. The code base itself should render a URI without unintentionally triggering a redirect/307 that gets caught by the externality of a web server / fastapi configuration or whatnot (in this comment it looks like nginx). I believe that fixing the code will render all scenarios valid here. I'll push a PR in a minute since this just tripped me up too!