Repository navigation
Conversation
Contributor
Author
|
also asking review from @dm-vodopyanov @KornevNikita (king ping :) ) thanks! |
KornevNikita
reviewed
Oct 9, 2026
KornevNikita
left a comment
KornevNikita
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Also, this class doesn't provide hidden friend operators
Contributor
Author
Should they be added in this PR or a follow-up issue+PR ? |
Contributor
It's up to you. I guess it'd be easier to just add it in this PR |
Contributor
Author
Ok, I think I implemented it correctly, can you please take another look? |
KornevNikita
approved these changes
Oct 9, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #23397
follow up of #23184
Adds
noexceptkeyword to move constructor & assignment, as well as default explicit destructorGuards old member operators in favor of hidden friend operators as per SYCL spec