Repository navigation
fix: Update remote RPyC service reference in tunnel connection setup - #50
Open
adrianlasota wants to merge 1 commit into
Open
adrianlasota wants to merge 1 commit into
adrianlasota wants to merge 1 commit into
Conversation
Contributor
|
We don't publish DEVs .whl. |
adrianlasota
force-pushed
the
tunneled_rpyc_fix
branch
2 times, most recently
from
September 25, 2026 07:29
e02097c to
6e313ae
Compare
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
Reconnect handling still uses the local RPyC context instead of restoring the tunneled remote setup.
Review effort: Lite
Findings: None
What changed in this PR
Updates tunneled RPyC setup to use remote module references for services and background threads.
Changes:
- Uses remote
ClassicServiceandBgServingThread. - Removes unused local RPyC imports.
- Updates tests for remote object usage.
| File | Summary |
|---|---|
tests/unit/test_mfd_connect/test_tunneled_rpyc.py |
Updates mocks and coverage for remote RPyC objects. |
mfd_connect/tunneled_rpyc.py |
Resolves RPyC services and threads through the tunnel. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
mchromin
previously approved these changes
Sep 25, 2026
Signed-off-by: Lasota, Adrian <adrian.lasota@intel.com>
adrianlasota
force-pushed
the
tunneled_rpyc_fix
branch
from
September 25, 2026 07:45
6e313ae to
f690c85
Compare
mchromin
approved these changes
Oct 2, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the way
rpycservices and background serving threads are referenced and imported intunneled_rpyc.py. The changes ensure that allrpyc-related objects are accessed through the tunneled connection's modules, improving compatibility and correctness when working with remote Python environments.Improvements to remote module handling:
ClassicServiceandBgServingThreadto useremote_rpycfrom the tunneled connection's modules, instead of importing them directly. This ensures that remote objects are properly referenced and avoids issues with local/remote context mismatches.Code cleanup:
rpycandClassicServicefromtunneled_rpyc.py, since these are now accessed via the remote modules interface.