Skip to content

fix: Update remote RPyC service reference in tunnel connection setup - #50

Open
adrianlasota wants to merge 1 commit into
mainfrom
tunneled_rpyc_fix
Open

adrianlasota wants to merge 1 commit into
mainfrom
tunneled_rpyc_fix

Conversation

@adrianlasota

Copy link
Copy Markdown
Contributor

This pull request updates the way rpyc services and background serving threads are referenced and imported in tunneled_rpyc.py. The changes ensure that all rpyc-related objects are accessed through the tunneled connection's modules, improving compatibility and correctness when working with remote Python environments.

Improvements to remote module handling:

  • Updated the instantiation of ClassicService and BgServingThread to use remote_rpyc from the tunneled connection's modules, instead of importing them directly. This ensures that remote objects are properly referenced and avoids issues with local/remote context mismatches.

Code cleanup:

  • Removed unused direct imports of rpyc and ClassicService from tunneled_rpyc.py, since these are now accessed via the remote modules interface.

@mfd-intel-bot

Copy link
Copy Markdown
Contributor

We don't publish DEVs .whl.
To build .whl, run 'pip install git+https://github.com/intel/mfd-connect@tunneled_rpyc_fix'

@adrianlasota
adrianlasota force-pushed the tunneled_rpyc_fix branch 2 times, most recently from e02097c to 6e313ae Compare September 25, 2026 07:29
@coveralls-official

coveralls-official Bot commented Sep 25, 2026 •

Copy link
Copy Markdown

Coverage Status

coverage: 80.869% (+0.04%) from 80.829% — tunneled_rpyc_fix into main

@adrianlasota
adrianlasota marked this pull request as ready for review September 25, 2026 07:32
Copilot AI lite review requested due to automatic review settings September 25, 2026 07:32

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🔵 Needs a closer look

Reconnect handling still uses the local RPyC context instead of restoring the tunneled remote setup.

Review effort: Lite
Findings: None

What changed in this PR

Updates tunneled RPyC setup to use remote module references for services and background threads.

Changes:

  • Uses remote ClassicService and BgServingThread.
  • Removes unused local RPyC imports.
  • Updates tests for remote object usage.
File Summary
tests/​unit/​test_mfd_connect/​test_tunneled_rpyc.py Updates mocks and coverage for remote RPyC objects.
mfd_connect/​tunneled_rpyc.py Resolves RPyC services and threads through the tunnel.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

mchromin
mchromin previously approved these changes Sep 25, 2026
Signed-off-by: Lasota, Adrian <adrian.lasota@intel.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants