Repository navigation
feat: Add E835 device IDs for Backplane, QSFP, and SFP Controllers - #12
Merged
Merged
Conversation
Copilot
AI
changed the title
[WIP] Extend module for Backplane, QSFP, and SFP controllers
Add E835 device IDs for Backplane, QSFP, and SFP Controllers
Oct 21, 2025
adrianlasota
marked this pull request as ready for review
October 21, 2025 07:26
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for Intel E835 network controllers across three variants (CC, C, and L) for backplane, QSFP, and SFP configurations. Nine new device IDs are integrated into the Connorsville (CNV) family and classified as 100G devices with ICE driver support.
Key changes:
- Added 9 E835 device IDs (0x1248-0x124A, 0x1261-0x1263, 0x1265-0x1267) to Family.CNV
- Classified all E835 devices as 100G in the NIC installer mapping
- Mapped all E835 devices to the ICE driver
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
mfd_const/network.py |
Added 9 E835 device IDs to CNV family, 100G classification, and ICE driver mapping |
tests/unit/test_mfd_const/test_mfd_const.py |
Added 3 test methods to verify E835 device IDs in CNV family, 100G classification, and ICE driver mapping |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
mkwasile
approved these changes
Oct 21, 2025
adrianlasota
force-pushed
the
copilot/extend-backplane-qsfp-sfp-module
branch
2 times, most recently
from
October 21, 2025 08:02
b9365f6 to
07ff940
Compare
adrianlasota
changed the title
Contributor
|
We don't publish DEVs .whl. |
(0x1248, 0x1249, 0x124A, 0x1261, 0x1262, 0x1263, 0x1265, 0x1266, 0x1267) to 100G_CNV Co-authored-by: adrianlasota <64520076+adrianlasota@users.noreply.github.com> Signed-off-by: Lasota, Adrian <adrian.lasota@intel.com>
adrianlasota
force-pushed
the
copilot/extend-backplane-qsfp-sfp-module
branch
from
October 21, 2025 08:06
07ff940 to
926f642
Compare
mchromin
approved these changes
Oct 21, 2025
adrianlasota
approved these changes
Oct 27, 2025
abaczek
approved these changes
Oct 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR extends the module with support for Intel E835 controllers across three variants (CC, C, and L) for backplane, QSFP, and SFP configurations. These new device IDs are added to the Connorsville (CNV) family as 100G devices.
Device IDs Added
Backplane Controllers
0x1248- E835-CC for backplane0x1261- E835-C for backplane0x1265- E835-L for backplaneQSFP Controllers
0x1249- E835-CC for QSFP0x1262- E835-C for QSFP0x1266- E835-L for QSFPSFP Controllers
0x124A- E835-CC for SFP0x1263- E835-C for SFP0x1267- E835-L for SFPChanges Made
Family.CNV: Added 9 new E835 device IDs to the Connorsville family inDEVICE_IDSDEVID_CLASS_MAP_NICINSTALLER["100G"]to classify them as 100G devicesDRIVER_DEVICE_ID_MAP["ice"]to associate them with the ICE driverVerification
SPEED_IDS["@100G"]through Family.CNV inheritanceThe changes maintain backward compatibility and follow the existing code structure and patterns.
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.