Repository navigation
fix: Move GNR-D device ID's to Family.GNRD from Family.CPK - #16
Merged
Merged
Conversation
Signed-off-by: Kacper Tokarzewski <kacper.tokarzewski@intel.com>
There was a problem hiding this comment.
Pull Request Overview
This PR corrects the device family classification for GNR-D network devices by moving device IDs 0x579C, 0x579D, 0x579E, and 0x579F from the CPK family to the GNRD family where they belong.
Key Changes:
- Relocated four device IDs (
0x579C,0x579D,0x579E,0x579F) fromCPK_SMBMfamily toGNRDfamily - Updated the
scebgroup to include all four device IDs (previously only contained0x579Cand0x579D) - Ensured consistency across both string-based and DeviceID-based data structures
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
adrianlasota
approved these changes
Nov 17, 2025
mchromin
approved these changes
Nov 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the device ID assignments for several network device families in
mfd_const/network.py. The main change is the reallocation of the device IDs0x579C,0x579D,0x579E, and0x579Ffrom theCPK_SMBMfamily to theGNRDfamily and thescebgroup, ensuring that device ID mappings are accurate and consistent.Device ID reallocation:
0x579C,0x579D,0x579E, and0x579Ffrom theCPK_SMBMfamily assignment lists and tuples. [1] [2] [3]0x579C,0x579D,0x579E, and0x579Fto theGNRDfamily assignment lists and tuples. [1] [2]scebgroup to include device IDs0x579Eand0x579F, in addition to the existing0x579Cand0x579D.