Skip to content

chore: align CI and bump test dependencies - #23

Merged
adrianlasota merged 2 commits into
mainfrom
chore/align-ci-and-test-deps
May 29, 2026
Merged

adrianlasota merged 2 commits into
mainfrom
chore/align-ci-and-test-deps

Conversation

@abaczek

@abaczek abaczek commented May 28, 2026

Copy link
Copy Markdown
Contributor

Summary

  • bump pytest/mfd-code-quality requirements where applicable
  • align GitHub Actions wrappers with intel/mfd-connect templates

Validation

  • git diff --check
  • YAML parse for .github/**/*.yml
  • pytest -q

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: abaczek <arkadiusz.baczek@intel.com>
Copilot AI review requested due to automatic review settings May 28, 2026 15:11

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Aligns CI workflow wrappers in this repo with the templates used in intel/mfd-connect (removing redundant secrets/with inputs that the reusable workflows now derive themselves, and converting codeql.yml from an inline CodeQL setup into a thin wrapper over intel/mfd/.github/workflows/codeql.yml@main) and bumps the test toolchain.

Changes:

  • Bump test deps: pytest to >= 9.0.3, < 10 and mfd-code-quality to >= 1.4.1, < 2.
  • Trim reusable-workflow wrappers (run_tests.yml, pull_request.yml, main.yml, manual_release.yml, check_code_standard.yml, check_pr_format.yml) to match the upstream template.
  • Replace inline CodeQL workflow with the reusable intel/mfd/.github/workflows/codeql.yml@main wrapper.

Reviewed changes

Copilot reviewed 9 out of 10 changed files in this pull request and generated 7 comments.

Show a summary per file
File Description
requirements-test.txt Bump pytest constraint to >= 9.0.3, < 10.
requirements-dev.txt Bump mfd-code-quality lower bound to 1.4.1.
.github/workflows/run_tests.yml Drop secrets, REPOSITORY_NAME, BRANCH_NAME inputs from wrapper.
.github/workflows/pull_request.yml Reformat existing inputs/secrets block.
.github/workflows/main.yml Reformat existing inputs/secrets block.
.github/workflows/manual_release.yml Reformat existing inputs/secrets block.
.github/workflows/check_code_standard.yml Drop GH_TOKEN secret; add PYTHON_VERSION input.
.github/workflows/check_pr_format.yml Reformat existing inputs block.
.github/workflows/codeql.yml Replace inline CodeQL setup with reusable workflow wrapper.
.github/dependency_review.yml Whitespace-only change on trailing line.

Note: Across every modified workflow, the GitHub Actions expressions are written as ${{ ... } (single closing brace) instead of ${{ ... }}. As shown, this is invalid expression syntax and will break the workflows. If this is an artifact of how the diffs were rendered for review rather than the actual file content, please ignore — but the file content I read from disk for run_tests.yml and codeql.yml does show the single brace.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/run_tests.yml Resolved
Comment thread .github/workflows/pull_request.yml Resolved
Comment thread .github/workflows/manual_release.yml Resolved
Comment thread .github/workflows/main.yml Resolved
Comment thread .github/workflows/codeql.yml Resolved
Comment thread .github/workflows/check_pr_format.yml Resolved
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: abaczek <arkadiusz.baczek@intel.com>
@abaczek
abaczek force-pushed the chore/align-ci-and-test-deps branch from 2056164 to a8c8b26 Compare May 28, 2026 15:30
@mfd-intel-bot

Copy link
Copy Markdown
Contributor

We don't publish DEVs .whl.
To build .whl, run 'pip install git+https://github.com/intel/mfd-const@chore/align-ci-and-test-deps'

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@adrianlasota
adrianlasota merged commit ca20fd8 into main May 29, 2026
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants