Repository navigation
feat: add iproute2 dcb tool support (ETS/PFC/APP) - #8
Merged
Merged
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
APP parsing loses repeated protocol entries and misidentifies overlapping selectors.
1 open issue
What changed in this PR
Adds iproute2 dcb support alongside the existing Linux DCB tools.
Changes:
- Adds ETS, PFC, and APP configuration readers.
- Extends Linux APIs with tool selection and APP management.
- Adds usage examples and unit tests.
| File | Description |
|---|---|
| tests/unit/test_mfd_dcb/test_linux.py | Tests new commands and legacy behavior. |
| tests/unit/test_mfd_dcb/test_dcb_wrapper.py | Tests parsing and error handling. |
| mfd_dcb/linux.py | Integrates tool selection and configuration commands. |
| mfd_dcb/enums.py | Adds the DCB tool enum. |
| mfd_dcb/dcb_wrapper.py | Implements iproute2 configuration readers. |
| examples/linux_example.py | Demonstrates the new APIs. |
Review effort: Balanced
adrianlasota
requested changes
Oct 21, 2026
adrianlasota
requested changes
Oct 21, 2026
lkaliszc
force-pushed
the
MFD-9559
branch
4 times, most recently
from
October 22, 2026 10:19
dfbe536 to
18a5b01
Compare
adrianlasota
requested changes
Oct 22, 2026
lkaliszc
force-pushed
the
MFD-9559
branch
2 times, most recently
from
October 22, 2026 14:42
93f359b to
3fd0b0d
Compare
adrianlasota
requested changes
Oct 23, 2026
adrianlasota
requested changes
Oct 23, 2026
Signed-off-by: Kaliszczuk, Leszek <leszek.kaliszczuk@intel.com>
adrianlasota
approved these changes
Oct 26, 2026
abaczek
approved these changes
Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This pull request introduces support for the Linux
iproute2 dcbtool for reading and configuring Data Center Bridging (DCB) settings, alongside the legacy tools. It adds a newDcbCliclass for interacting with thedcbtool, extends the API to allow selecting the tool, and provides comprehensive unit tests for the new functionality.New DCB tool support:
DcbCliclass inmfd_dcb/dcb_wrapper.pyto provide get/set operations for ETS, PFC, and APP tables via theiproute2 dcbcommand, including robust output parsing and error handling.DcbToolTypeenum inmfd_dcb/enums.pyto select between legacy anddcbtools for configuration.API extensions and integration:
mfd_dcb/linux.pyto addtoolparameters toset_ets,set_pfc, and new APP table management methods (set_app,del_app,replace_app,flush_app), allowing explicit selection of the DCB tool and supporting the newdcb-based workflows. [1] [2] [3] [4] [5]DcbCliwhentool_name == "dcb".Examples and tests:
examples/linux_example.pyto demonstrate setting and reading DCB configuration using the newdcbtool and the extended API. [1] [2]DcbCliintests/unit/test_mfd_dcb/test_dcb_wrapper.py, covering parsing, error handling, and merged configuration retrieval.