Repository navigation
feat: Allow filtering interface using mac_address - #15
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds support for filtering topology-defined network interfaces by mac_address when resolving InterfaceInfo via mfd-network-adapter.
Changes:
- Passes
interface_model.mac_addressinto_filter_interfaces_info. - Preserves existing topology-based filters such as PCI address, device, family, speed, names, and random selection.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mchromin
requested changes
May 14, 2026
|
coverage: 94.021% (+0.005%) from 94.016% — dhiraj3880:filter_mac_address into intel:main |
dhiraj3880
force-pushed
the
filter_mac_address
branch
from
May 14, 2026 15:10
b8361b1 to
a3fd8b3
Compare
Specifying a mac_address in topology also requires the interface getting filtered in the call to mfd-network-adapter. Signed-off-by: Dhiraj Lulla <dhiraj.lulla@intel.com>
dhiraj3880
force-pushed
the
filter_mac_address
branch
from
May 14, 2026 21:42
a3fd8b3 to
98863bc
Compare
adrianlasota
approved these changes
May 15, 2026
mchromin
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Specifying a mac_address in topology also requires the interface getting filtered in the call to mfd-network-adapter