Repository navigation
Conversation
|
coverage: 95.451% (+1.4%) from 94.021% — efi_shell into main |
There was a problem hiding this comment.
Pull request overview
Adds first-class support for the EFI Shell (UEFI Shell) OS to the mfd_host framework by introducing a dedicated host subclass and wiring it into the Host factory, along with tests and minor documentation/example updates.
Changes:
- Added
EFIShellHost(mfd_host/efishell.py) and registered it inHost.__new__OS dispatch. - Extended unit tests to validate EFI Shell host instantiation and property behavior (including unsupported features).
- Updated documentation (supported OS list) and added a simple example for EFI Shell host creation.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/unit/test_mfd_host/test_base.py | Adds EFIShellHost creation test and property-level behavior tests (supported/unsupported features). |
| README.md | Lists EFI Shell among supported OSes. |
| mfd_host/efishell.py | Introduces EFIShellHost with OS gating via os_supported. |
| mfd_host/base.py | Registers OSName.EFISHELL in the Host factory mapping. |
| examples/simple_example.py | Adds an EFI Shell instantiation example using an mfd_connect connection type. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Lasota, Adrian <adrian.lasota@intel.com>
Contributor
|
We don't publish DEVs .whl. |
mchromin
approved these changes
Jun 8, 2026
a-gorczew
approved these changes
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds support for the EFI Shell (UEFI Shell) operating system to the MFD host framework. It introduces a new
EFIShellHostclass, updates the mainHostfactory logic to recognize EFI Shell, and extends the test suite to cover the new OS type and its properties.New EFI Shell OS support:
EFIShellHostclass inmfd_host/efishell.py, implementing host support for UEFI Shell OS.EFIShellHostin theHostfactory (mfd_host/base.py) so that instances are created automatically when the connection OS is EFI Shell.README.mdto include EFI Shell.Testing and documentation:
EFIShellHostto verify property behaviors and correct instantiation, including checks for supported and unsupported features. [1] [2]examples/simple_example.pyto demonstrate how to instantiate an EFI Shell host. [1] [2]Other:
These changes ensure that the MFD host framework can now work with systems running in the UEFI Shell environment, with appropriate test coverage and documentation.