Repository navigation
feat: [ESXi] CPU measurement using esxtop - #4
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR introduces CPU measurement functionality for ESXi hosts using the esxtop tool. The implementation allows starting a CPU measurement process, collecting data over time, and parsing the results to calculate average CPU usage for specific VMs.
Key Changes:
- Added methods to start/stop CPU measurement processes using
esxtopcommand - Implemented parsing logic to extract and average CPU usage data from the last 4 samples
- Added comprehensive unit tests covering normal operation, edge cases, and error handling
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| mfd_host/feature/cpu/esxi.py | Implements three new methods for CPU measurement: start, stop, and parse operations with error handling and process management |
| tests/unit/test_mfd_host/test_feature/test_cpu/test_esxi.py | Adds 8 unit tests covering measurement lifecycle, parsing logic, error conditions, and edge cases |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
szmijews
force-pushed
the
cpu_usage_per_vm
branch
2 times, most recently
from
December 2, 2025 14:06
c50ac5b to
90776eb
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
szmijews
force-pushed
the
cpu_usage_per_vm
branch
from
December 2, 2025 14:20
90776eb to
68be7e4
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
szmijews
force-pushed
the
cpu_usage_per_vm
branch
2 times, most recently
from
December 4, 2025 17:08
dd1fd2f to
6facf29
Compare
szmijews
force-pushed
the
cpu_usage_per_vm
branch
from
December 16, 2025 15:36
6facf29 to
150c503
Compare
mchromin
requested changes
Dec 17, 2025
szmijews
force-pushed
the
cpu_usage_per_vm
branch
from
December 17, 2025 08:55
150c503 to
a21962e
Compare
mchromin
previously approved these changes
Dec 17, 2025
szmijews
force-pushed
the
cpu_usage_per_vm
branch
from
December 18, 2025 16:45
a21962e to
c5f207c
Compare
szmijews
force-pushed
the
cpu_usage_per_vm
branch
from
December 18, 2025 16:55
c5f207c to
552d22d
Compare
adrianlasota
changed the title
szmijews
force-pushed
the
cpu_usage_per_vm
branch
2 times, most recently
from
December 19, 2025 08:31
d995127 to
02a3627
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
adrianlasota
requested changes
Dec 19, 2025
adrianlasota
requested changes
Dec 19, 2025
szmijews
force-pushed
the
cpu_usage_per_vm
branch
from
December 19, 2025 13:00
02a3627 to
7d02cda
Compare
Introduce methods for measuring CPU usage with esxtop tool + unit tests Signed-off-by: szmijews <szymon.zmijewski@intel.com>
szmijews
force-pushed
the
cpu_usage_per_vm
branch
from
December 19, 2025 13:00
7d02cda to
d97a497
Compare
adrianlasota
approved these changes
Dec 19, 2025
mchromin
approved these changes
Dec 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce methods for measuring CPU usage with esxtop tool + unit tests
fixes #3