Repository navigation
fix: delegate VM RPyC readiness to RPyCConnection retry mechanism - #25
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot couldn't run its full agentic review because no GitHub Actions runner was available. Make sure your repository has a runner available to run Copilot's review, or add a copilot-setup-steps.yml file specifying one with the runs-on attribute. See the docs for more details.
This PR makes VM creation more reliable by waiting for the VM’s RPyC responder port to accept TCP connections before instantiating RPyCConnection, preventing transient connection-refused failures right after DHCP IP assignment.
Changes:
- Add
_wait_vm_rpyc_ready()to poll the RPyC TCP port until ready or timeout. - Call
_wait_vm_rpyc_ready()duringcreate_vm()after management IP is obtained. - Extend unit tests and existing fixtures to cover the new readiness wait.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| mfd_hyperv/hypervisor.py | Adds an active TCP port readiness wait and wires it into VM creation flow. |
| tests/unit/test_mfd_hyperv/test_hypervisor.py | Updates existing tests to mock the new wait and adds new unit tests for readiness polling. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
adrianlasota
requested changes
Jul 7, 2026
mkwasile
changed the title
adrianlasota
requested changes
Jul 7, 2026
mkwasile
force-pushed
the
poll_rpyc_port
branch
3 times, most recently
from
July 8, 2026 08:17
e277bd7 to
f7093b3
Compare
fix: Add retry_timeout and retry_time parameters to create_vm(), forwarded directly to RPyCConnection to handle connection retries natively. Signed-off-by: mwasile <marek.wasilewski@intel.com>
adrianlasota
approved these changes
Jul 8, 2026
mchromin
approved these changes
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: Add retry_timeout and retry_time parameters to create_vm(), forwarded
directly to RPyCConnection to handle connection retries natively.