Repository navigation
fix: Use rsync to copy VM image where available - #18
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Existing destinations may bypass content copying, and the added command probe breaks current test mocks.
Review effort: Balanced
Findings: 1
What changed in this PR
Uses rsync for reliable VM image cloning, with scp as a fallback.
Changes:
- Detects
rsyncavailability. - Selects
rsyncorscpfor cloning.
| File | Description |
|---|---|
mfd_kvm/hypervisor.py |
Adds rsync-based VM image copying with fallback. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
mlandowski-intel
force-pushed
the
copy_with_rsync
branch
2 times, most recently
from
October 6, 2026 16:39
18187b4 to
9bd0d3f
Compare
KTokarze
approved these changes
Oct 6, 2026
adrianlasota
requested changes
Oct 7, 2026
mlandowski-intel
force-pushed
the
copy_with_rsync
branch
from
October 7, 2026 09:07
9bd0d3f to
3f580de
Compare
adrianlasota
requested changes
Oct 7, 2026
mlandowski-intel
force-pushed
the
copy_with_rsync
branch
from
October 7, 2026 09:24
3f580de to
81fe2dc
Compare
adrianlasota
requested changes
Oct 7, 2026
Signed-off-by: Marek Landowski <marek.landowski@intel.com>
mlandowski-intel
force-pushed
the
copy_with_rsync
branch
from
October 7, 2026 09:49
81fe2dc to
006283c
Compare
adrianlasota
approved these changes
Oct 7, 2026
mchromin
approved these changes
Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
scp tool has been observed to occasionally corrupt VM images when used to clone them in clone_vm_hdd_image. To resolve this, replace it with rsync as a primary method, while leaving scp as a fallback, as rsync might not be available on some minimal Linux images.