Repository navigation
feat: Improvements in clone_vm_hdd_image logic - #19
Merged
Merged
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
Invalid or zero source-size output can still crash progress reporting.
1 open finding
What changed in this PR
Improves VM HDD cloning efficiency and remote-path correctness.
Changes:
- Reuses source checksum files and skips matching clones.
- Converts paths to connection-owned paths.
- Adds safer progress reporting checks.
| File | Description |
|---|---|
mfd_kvm/hypervisor.py |
Updates cloning and checksum logic. |
tests/unit/test_mfd_kvm/test_hypervisor.py |
Expands cloning tests. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
mlandowski-intel
force-pushed
the
rsync_improvements
branch
from
October 12, 2026 08:01
d868452 to
56b1b1a
Compare
mchromin
previously approved these changes
Oct 12, 2026
adrianlasota
requested changes
Oct 12, 2026
mlandowski-intel
force-pushed
the
rsync_improvements
branch
3 times, most recently
from
October 13, 2026 08:14
9d012dc to
5ebcbfa
Compare
adrianlasota
previously approved these changes
Oct 13, 2026
Signed-off-by: Marek Landowski <marek.landowski@intel.com>
mlandowski-intel
force-pushed
the
rsync_improvements
branch
from
October 13, 2026 08:24
5ebcbfa to
d0009c1
Compare
adrianlasota
approved these changes
Oct 13, 2026
mchromin
approved these changes
Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improvements in clone_vm_hdd_image for better execution time and robustness
-check file checksum only if destination file exists to avoid doing it when the check is moot
-use pre-generated md5 sums at source to save on time by avoiding recalculating them over network
-add verification if cloning progress can be safely reported
-convert input paths to connection-owned so all existence and checksum checks run on SUT