[lkleinax]

This pull request enhances the clone_vm_hdd_image functionality in mfd_kvm/hypervisor.py by improving error handling, adding more detailed progress tracking for rsync-based image cloning, and updating the unit tests to reflect these changes. The main improvements are stricter source file validation, more informative logging and progress updates during cloning, and more robust test coverage for both rsync and scp scenarios.

Key changes:

Error Handling and Validation

• The function now raises a FileNotFoundError immediately if the source image file does not exist, instead of checking later or after a timeout. [1] [2]

Cloning Process Improvements

• When using rsync, the command now includes -av --info=progress2 --outbuf=N for verbose output and real-time progress, and logs are captured for progress parsing.
• During the cloning loop, if rsync is used, the code reads the log file to parse and log detailed progress, including percentage completed, and handles possible errors in reading the log.

Test Enhancements

• All relevant tests are updated to expect the new rsync command parameters and the use of the log_file argument. [1] [2] [3] [4]
• New tests are added to specifically verify the progress reporting for both scp and rsync cloning, including parsing of rsync output and checking for accurate log messages.
• Test assertions are updated to check log messages in a more robust way by extracting messages from log records instead of searching raw log text. [1] [2]

Code Quality and Robustness

• Refactored command execution and logging for better maintainability and clarity, including improved error reporting if reading the rsync log fails.
• Minor test cleanup for edge cases and improved mocking to ensure correct behavior in all scenarios.

[Copilot]

Warning

Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.

Copilot review overview

3 open issues

• last_line.strip().split()[0] can raise IndexError if the parsed chunk is empty/whitespace… · New
• The command composition relies on params containing leading/trailing spaces and on implicit… · New
• Reading the entire rsync log file every 30 seconds (cat -A) can become increasingly expensive on… · New

What changed in this PR

Updates VM disk image cloning to better track rsync copy progress (Fixes #20) by switching to rsync progress output captured in a log file and parsing it to compute cloning status.

Changes:

• Update the rsync invocation to include progress output and enable logging to a file.
• Add rsync-specific progress parsing logic in clone_vm_hdd_image() and adjust timeout-loop behavior accordingly.
• Update/add unit tests to cover rsync vs scp behavior and progress reporting.

File	Description
mfd_kvm/​hypervisor.py	Switch rsync command to emit progress, capture output to a log file, and parse progress status during the cloning loop.
tests/​unit/​test_mfd_kvm/​test_hypervisor.py	Update expectations for the new rsync command/logging behavior and add tests for rsync vs scp “still cloning” progress messages.

_{Review effort: Lite}

[Copilot]

Warning

Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.

Copilot review overview

7 open issues

• last_line.strip().split()[0] can raise IndexError if the parsed chunk is empty/whitespace…
• The FileNotFoundError message is grammatically awkward and not very actionable. Consider a clearer,… · New
• Reading the full rsync log via cat -A on every polling interval can become increasingly expensive… · New
• The condition path_to_destination_image.name in last_line is unlikely to match typical rsync… · New
• This method otherwise uses the module logger for logging, but progress logs are sent via the root… · New
• Reading the entire rsync log file every 30 seconds (cat -A) can become increasingly expensive on…
• The command composition relies on params containing leading/trailing spaces and on implicit…

_{Review effort: Lite}