Repository navigation
feat: Configure transmit LLDP on interface - #51
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds Linux LLDP support for configuring and reading the interface “transmit LLDP” sysfs knob.
Changes:
- Added
set_transmit_lldp_on_interface()to enable/disable transmit LLDP via sysfs. - Added
get_transmit_lldp_status()to read and parse transmit LLDP status. - Added unit tests covering enabled/disabled writes and basic parsing/error scenarios.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| tests/unit/test_mfd_network_adapter/test_network_interface/test_feature/test_lldp/test_lldp_linux.py | Adds unit tests for setting and reading transmit LLDP sysfs state. |
| mfd_network_adapter/network_interface/feature/lldp/linux.py | Implements sysfs-based setters/getters for transmit LLDP on Linux. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mchromin
requested changes
May 21, 2026
mchromin
previously approved these changes
May 26, 2026
a-gorczew
previously approved these changes
May 26, 2026
Create methods for configuring and reading transmit LLDP status on Linux Network Interface @signed-off-by: szmijews <szymon.zmijewski@intel.com>
mchromin
approved these changes
May 28, 2026
adrianlasota
approved these changes
May 28, 2026
a-gorczew
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Create methods for configuring and reading transmit LLDP status on Linux Network Interface
addresses #52
@signed-off-by: szmijews szymon.zmijewski@intel.com