migrated rohd_source_navigator to packages, prepped for publication - #718
Conversation
mkorbel1
left a comment
There was a problem hiding this comment.
Requesting changes so this branch is ready to release both rohd_source_navigator 0.1.0 and a rohd_devtools_widgets 0.1.1 patch containing the dependency-constraint bug fix. The inline comments cover package CI/Pana coverage, the widgets release and minimum dependency, and package-specific documentation. Please prepare and validate both selected packages; publication remains a separate maintainer step.
At b6eefaf, the source-navigator preparation workflow passed in a clean disposable checkout: formatting, analysis, all 20 tests, and a publication dry run with zero warnings. The release helpers also passed 59 shell regression checks and 9 metadata tests. These results cover navigator and the helpers, not the proposed widgets 0.1.1 release or its preferred ROHD ^0.6.10 floor, which still need package-level validation. No packages were published.
mkorbel1
left a comment
There was a problem hiding this comment.
The earlier CI, hosted dependency validation, widgets version/floor, and package documentation requests have been addressed. The remaining release-readiness requests are useful examples for all four packages, support for the current JSON-RPC dependency in navigator, and enforcing Pana scores through the shared CI/preparation runner, with a temporary navigator-only 10-point allowance for its pre-merge repository URL. There is also a small changelog formatting nit.
The release scope remains rohd_source_navigator 0.1.0 and rohd_devtools_widgets 0.1.1. Hierarchy and waveform do not need version bumps or new releases solely for the example/Pana improvements; those changes can land here and ship with their next otherwise-needed releases. Publication remains a separate maintainer step.
Validation already completed at ebd3b64: preparation for both selected packages, hosted normal and lower-bound analysis, Pana reports, and publication dry runs passed under the current scripts; widgets also passed 54 tests with hosted dependencies and no checkout overrides. Those results do not establish the stricter Pana gate requested here: the current scores are advisory. Tests were not rerun for this review submission, and no packages were published.
mkorbel1
left a comment
There was a problem hiding this comment.
The earlier package CI, dependency/SDK, Pana score, example, and documentation requests have been addressed. I found no additional package-code blocker in the final pass. Please address the two remaining tooling requests inline: run all seven shell regression suites in CI, and make local Pana scoring opt-in while preserving the mandatory CI gate. The local opt-in request supersedes my earlier request to run Pana unconditionally during preparation.
At c816e86, current CI is green, all seven tooling suites passed locally (117 checks), and fresh hosted-dependency publication dry runs for rohd_source_navigator 0.1.0 and rohd_devtools_widgets 0.1.1 passed with zero warnings. These results were already completed during the review; tests and Pana were not rerun for submission.
The release scope remains navigator 0.1.0 and widgets 0.1.1; no root, hierarchy, or waveform release is needed for these changes. Basic examples are sufficient, and no README link rewrite is requested: canonical main destinations remain unavailable until merge under the chosen publish-before-merge workflow. Publication remains a separate maintainer step. No packages were published.
mkorbel1
left a comment
There was a problem hiding this comment.
Approved! ready to publish!
Description & Motivation
Our rohd_source_navigator code was left private and we need it published for use by applications like rohd-schematic-viewer.
Related Issue(s)
None.
Testing
Ran existing tests.
Backwards-compatibility
Yes. Any application pointing to this code via a git path will need to use the pub.dev copy.
Documentation
Yes. The package was added to all places where we discuss maintaining external packages.