Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description & Motivation
Improve generated SystemVerilog when multiple scalar submodule outputs feed a parent output bus through
Logic.assignSubset. These connections can now map directly to destination bits, such as.result(observed[2]), instead of retaining intermediate wires and separate assignments.The optimization applies to fully covered parent output buses, including connections through clearable full-width aliases. Existing safety checks for fanout, overlapping assignments, preserved names, constants, partial coverage, and net/array boundaries remain in place. Internal-bus concatenation behavior is unchanged.
Related Issue(s)
N/A
Testing
Added 157 synthetic regression cases covering producer topology, assignment order, alias depth, fanout, repeated source bits, preserved names, partial coverage, constants, mixed-width sources, 33/65-bit boundaries, and nested array consumers.
Tests check emitted port mappings, functional behavior, X/Z propagation, and repeat-synthesis stability with intervening netlist generation. Generated SystemVerilog is simulated with Icarus; unpacked-array integration uses Verilator for two-state simulation and ROHD for four-state checks.
Backwards-compatibility
No public API or functional behavior changes are intended. Generated SystemVerilog may contain fewer intermediate wires and assignments, so downstream checks that depend on exact generated text or internal signal names may need updates.
Documentation
No user-facing documentation updates are required. This improves synthesis output without changing how designs are written.