Check if compiler supports fcf-protection before setting it

[seijikun]

Basically the same as: uxlfoundation/oneTBB#1783

I am currently packaging xpumanager for openSUSE Tumbleweed and the build fails on platforms whose compiler does not support fcf-protection, like i586.
Would it be possible to check whether the compiler supports the -fcf-protection flag before setting it?

[savery42]

Sure thing, good habit either way :)

It's only a few lines in Meson so this should be more than fine to land in main today after internal reviews/validation. Will ping back on this issue when it's available.

[savery42]

Howdy @seijikun, fixed in 1532642

Let me know if there's anything else needed

[seijikun]

Thank you for the quick fix!
Builds just fine on all 64bit (aarch64 and x86_64) architectures now!

It currently doesn't build on i586 still, because of some size_t incompatibilities (i586_build.log) ...
But I think that platform is dead enough to ignore that.

[savery42]

Eh, valid enough for me, I'd prefer to avoid implicit conversions where-all possible even if we/Intel do not plan on officially supporting x86.

Can't promise it will merge as fast, but I'll add a clang-tidy pass for implicit conversions to/from size_t for hygiene.