Repository navigation
[raft] Remove locality and random packages and precompute ID - #1751
Conversation
mickmis
left a comment
There was a problem hiding this comment.
LGTM - the best kind of PRs :D
|
@MariemBaccari looks like that with this the |
|
@mickmis It is not used anymore indeed. However, it might be useful for observability to track locality in addition to the node ID for each proposal. What do you think ? |
One way or another we probably want to surface the locality at some point. Now, it is more of a free-text value configured at each node rather than an authoritative information. That would be coming from the certificate. The point I want to make here is that it is unclear now this is how we want to identify participants, and it might be misleading to include that already now. So I'd rather favor removing that field from the proposal for now and add it back later if that is needed. That will be much easier than removing it later if it ends up not being required. |
Following the efforts of pre-computing and validating as much as possible before proposing (e.g. #1714), this PR:
localitypackage which was unused since RID payloads now encapsulate the writer directly.randompackage and precomputes the implicit subscription UUID.