Repository navigation
Update implicitdict to 5.0.0 and fix revealed bugs - #1774
Merged
BenjaminPelletier merged 5 commits intoOct 7, 2026
Merged
Conversation
Bumps [implicitdict](https://github.com/interuss/implicitdict) from 4.1.0 to 5.0.0. - [Release notes](https://github.com/interuss/implicitdict/releases) - [Commits](interuss/implicitdict@v4.1.0...v5.0.0) --- updated-dependencies: - dependency-name: implicitdict dependency-version: 5.0.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
BenjaminPelletier
marked this pull request as ready for review
October 7, 2026 04:45
mickmis
approved these changes
Oct 7, 2026
Comment on lines
+208
to
+210
| if "time_start" in subscription | ||
| and subscription.time_start is not None | ||
| and "time_end" in subscription |
Contributor
There was a problem hiding this comment.
Do we actually want to check for "time_start" in subscription and "time_end" in subscription here? IIUC this is not required.
Member
Author
There was a problem hiding this comment.
Ah right, this is the primary thing this PR enables :)
github-actions Bot
added a commit
that referenced
this pull request
Oct 7, 2026
Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> bc18d5f
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dependabot bump of implictdict to 5.0.0 produced a number of hygiene errors due to the change of
__getattribute__'s implicit typing fromUnknown | AnytoUnknown | Any | None. I believe all these errors are latent bugs, just revealed now due to the typing change. This PR is a set of mostly-automated fixes for these bugs, plus some automatically-generated unit tests to verify behavior automatically.