Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR updates the plugin to target Jellyfin 12 and .NET 10, aligning build, packaging, and documentation with the new framework/ABI and simplifying linting/ruleset configuration. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The removal of
jellyfin.rulesetwithout a replacement means any custom analyzer/rule configuration tied to Jellyfin conventions will be lost; if that wasn’t intentional, consider either keeping it or migrating its settings into.editorconfigbefore dropping the file.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The removal of `jellyfin.ruleset` without a replacement means any custom analyzer/rule configuration tied to Jellyfin conventions will be lost; if that wasn’t intentional, consider either keeping it or migrating its settings into `.editorconfig` before dropping the file.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
![kilo-code-bot[bot]](https://avatars.githubusercontent.com/in/2193792?s=60&v=4){kind=small}
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (3 files)
Previous Review Summaries (21 snapshots, latest commit f11e240)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit f11e240)Status: No Issues Found | Recommendation: Merge Files Reviewed (3 files)
Previous review (commit f863459)Status: No Issues Found | Recommendation: Merge Files Reviewed (1 file)
Previous review (commit 22e85fb)Status: No Issues Found | Recommendation: Merge Files Reviewed (3 files)
Previous review (commit 2b6dc04)Status: 1 Issues Found | Recommendation: Address before merge Overview
Issue Details (click to expand)CRITICAL
Files Reviewed (3 files)
Fix these issues in Kilo Cloud Previous review (commit 85f4ce5)Status: No Issues Found | Recommendation: Merge Files Reviewed (4 files)
Previous review (commit 40f4a83)Status: No Issues Found | Recommendation: Merge Files Reviewed (2 files)
Previous review (commit 944d28f)Status: No Issues Found | Recommendation: Merge Files Reviewed (3 files)
Previous review (commit e999900)Status: No Issues Found | Recommendation: Merge Files Reviewed (3 files)
Previous review (commit b51f99f)Status: No Issues Found | Recommendation: Merge Files Reviewed (2 files)
Review NotesIncremental review of Previous review (commit 9aeaae9)Status: No Issues Found | Recommendation: Merge Files Reviewed (2 files)
Review NotesIncremental review of Previous review (commit 3cc4b58)Status: No Issues Found | Recommendation: Merge Files Reviewed (3 files)
Previous review (commit 18625c7)Status: No Issues Found | Recommendation: Merge Files Reviewed (3 files)
NotesThe incremental change since Prior review findings on Previous review (commit d5e0c9d)Status: No Issues Found | Recommendation: Merge Files Reviewed (3 files)
NotesThe incremental change since Prior review findings on Previous review (commit a28710f)Status: No Issues Found | Recommendation: Merge Files Reviewed (3 files)
NotesThe incremental change since Prior review findings on Previous review (commit 9a81686)Status: No Issues Found | Recommendation: Merge Files Reviewed (3 files)
NotesThe incremental change since Prior review findings on Previous review (commit a74d7b0)Status: No Issues Found | Recommendation: Merge Files Reviewed (4 files)
NotesThe incremental change updates the release workflow to target the No C# source files were changed in this diff, so the design-pattern review does not apply to the incremental changes. Prior review findings on Previous review (commit ebf053b)Status: No Issues Found | Recommendation: Merge Files Reviewed (3 files)
NotesThe incremental change since the prior review adds CI logic that derives the frontend SPA mount element id from the built Prior Previous review (commit 6976305)Status: No Issues Found | Recommendation: Merge Files Reviewed (3 files)
NotesThe incremental change since the prior review adds CI logic that derives the frontend SPA mount element id from the built Prior Previous review (commit eab3b80)Status: 3 Issues Found | Recommendation: Address before merge Overview
Issue Details (click to expand)SUGGESTION
Files Reviewed
Fix these issues in Kilo Cloud Previous review (commit 8517d52)Status: 3 Issues Found | Recommendation: Address before merge Overview
Issue Details (click to expand)SUGGESTION
Files Reviewed (10 files)
Fix these issues in Kilo Cloud Previous review (commit a4b7068)Status: 3 Issues Found | Recommendation: Address before merge Overview
Issue Details (click to expand)SUGGESTION
Files Reviewed (3 files)
NoteThis PR does not modify any C# source files ( Reviewed by gpt-6-luna · Input: 0 · Output: 0 · Cached: 0 |
…eries Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
ci(12.0): auto-release on segment-editor master updates via dispatch
![capy-ai-2[bot]](https://avatars.githubusercontent.com/in/4003883?s=60&v=4){kind=small}
![capy-ai[bot]](https://avatars.githubusercontent.com/in/1915919?s=60&v=4){kind=small}
The editor now builds with relative asset URLs so it works under a Jellyfin base URL. Those only resolve from the trailing-slash path, so redirect the bare route there with a relative Location that keeps any base URL or proxy prefix.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| // A relative Location keeps any Jellyfin base URL or proxy prefix intact. | ||
| if (Request.Path.Value?.EndsWith("/SegmentEditor", StringComparison.OrdinalIgnoreCase) == true) | ||
| { | ||
| return Redirect($"SegmentEditor/{Request.QueryString}"); |
2 participants
Jellyfin dependencies now use the stable-only
12.*floating version. Restores select the latest stable Jellyfin 12.x release (currently12.1.0), excluding prereleases and Jellyfin 13. The current minimum ABI and documented server requirement are 12.1. Each release derives its target ABI from the actually restored Jellyfin packages and commits it with the release metadata, so future stable 12.x updates cannot leave the advertised ABI behind.Verified dependency resolution, NuGet selection against future stable/prerelease/13 candidates, the .NET Release build (zero warnings/errors), formatting, actionlint, and release ABI synchronization/rejection cases. The frontend prerequisite intro-skipper/segment-editor#244 is merged. Rebuilt successfully from current frontend master, packaged the DLL, and verified all 68 embedded files plus entry-point/missing-asset cache headers on Jellyfin 12.1. Base-branch conflicts are resolved while preserving the Jellyfin 12 release version series and dispatch-only workflow. This direct update supersedes #18.
Summary by Sourcery
Upgrade the plugin for Jellyfin 12 while aligning frontend packaging, asset delivery, release automation, and documented compatibility requirements.
New Features:
Bug Fixes:
Enhancements:
Build:
Deployment:
Documentation:
Chores: