Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This replaces #203, which was accidentally closed and its source fork deleted. The implementation is unchanged; the original discussion and reviews remain linked there.
Fixes #202.
nested_hashsorts dictionary items and set members, which raisesTypeErrorwhen their types cannot be ordered, such as1and'one'. This also affects patch indexing inUnifier.Use order-independent frozenset hashing for sets and dictionary key/value-hash pairs. Lists retain their ordered hashing behavior. Regression tests cover mixed set members, mixed dictionary keys, nested mutable values, and equivalent containers built in a different order.
Validation: both new tests raise TypeError before the fix.
./run-tests.shpasses on Python 3.12 with NumPy installed: 128 tests, 100% coverage, documentation build/doctests and pycodestyle. Pytest emits the existing warning about the unrecognizedlive_server_scopesetting.