Repository navigation
Upgrade gobl.pt.saft to v0.0.8 - #59
Merged
Merged
Conversation
Brings in the order source rules: pt-saft-source is now defaulted and validated on bill.Order, which SAF-T requires on every work document. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
migueltorresvalls
requested review from
samlown
and
a balanced review from Copilot
September 30, 2026 09:15
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The dependency and checksums are consistent with the valid upstream v0.0.8 release.
Review effort: Balanced
Findings: None
What changed in this PR
Updates the Portuguese SAF-T addon to include order source defaults and validation from upstream PR #10.
Changes:
- Bumps
gobl.pt.saftfrom v0.0.7 to v0.0.8. - Updates module checksums.
| File | Description |
|---|---|
go.mod |
Updates the dependency version. |
go.sum |
Updates corresponding checksums. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #59 +/- ##
=======================================
Coverage 72.56% 72.56%
=======================================
Files 48 48
Lines 1994 1994
=======================================
Hits 1447 1447
Misses 467 467
Partials 80 80 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pick up the order source rules from invopop/gobl.pt.saft#10.
pt-saft-sourceis now defaulted toPand validated onbill.Order, matchingbill.Invoiceandbill.Payment. SAF-T requiresSourceBillingon every work document, so without it an order reaches a converter with no source and the element is emitted empty.Changes:
github.com/invopop/gobl.pt.saftv0.0.7 -> v0.0.8Notes: