Skip to content

fix: dark theme scoped token adaptation - #25

Merged
joaner merged 2 commits into
mainfrom
fix/dark-theme-scoped-tokens
Aug 10, 2026
Merged

fix: dark theme scoped token adaptation#25
joaner merged 2 commits into
mainfrom
fix/dark-theme-scoped-tokens

Conversation

@joaner

@joaner joaner commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Fix dark theme leaks caused by scoped .dark on .lerobot-root while body stays light: sidebar chrome, dialogs/sheets, and studio root now set bg-background / text-foreground together.
  • Point chart theme and portal fallbacks at .lerobot-root, and repair uPlot select/scrollbar CSS for full oklch tokens.
  • Harden error boundaries and shell surfaces; bump package to 1.0.2.

Test plan

  • npm run format:check, lint, typecheck
  • Local Playwright audit with dark theme + lerobotv3 fixture (sidebar tabs/splitter, export/health dialogs)
  • Light theme smoke check after toggle
  • CI green on this PR

joaner added 2 commits August 10, 2026 12:30
Ensure sidebar chrome, dialogs, charts, and portals resolve CSS tokens
from `.lerobot-root` so dark mode no longer inherits light body colors.
@joaner
joaner merged commit 788f46c into main Aug 10, 2026
7 checks passed
@joaner
joaner deleted the fix/dark-theme-scoped-tokens branch August 10, 2026 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant