blockservice: remove inner fields access methods#562
Closed
Jorropo wants to merge 1 commit into
Closed
Conversation
This was referenced Jan 15, 2024
Merged
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Jan 15, 2024
Jorropo
marked this pull request as draft
January 15, 2024 12:39
Jorropo
force-pushed
the
blockservice-unique
branch
from
January 15, 2024 12:57
12650a8 to
5e08a77
Compare
Jorropo
force-pushed
the
01-15-blockservice_remove_inner_fields_access_methods
branch
from
January 15, 2024 12:57
b60d216 to
17b3ed9
Compare
This was referenced Jan 15, 2024
Closed
We shouldn't expose inner implementation details of the blockservice to consumers. For example by using the blockstore for the .Has call, the gateway skipped verifcid and blocker checks. Probably fine but not we want to do.
Jorropo
force-pushed
the
blockservice-unique
branch
from
January 15, 2024 17:29
5e08a77 to
27a4b69
Compare
Jorropo
force-pushed
the
01-15-blockservice_remove_inner_fields_access_methods
branch
from
January 15, 2024 17:29
17b3ed9 to
8f9efef
Compare
This was referenced Jan 16, 2024
Jorropo
marked this pull request as ready for review
January 16, 2024 09:10
hacdias
removed their request for review
May 27, 2024 12:42
Contributor
|
Triage: make decision to keep this or close it |
gammazero
marked this pull request as draft
July 5, 2026 18:34
Contributor
|
This PR needs to be reworked. Too many things have changed since its creation and rebasing results in problems that need to be manually resolved. |
Contributor
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'll add changelog if we decide this is the option we want to go with.