Reactor to use cvs file for conventions and update bounds #5
Merged
Conversation
State variable (ST) timestamps now follow the ismip7-time-encoding reference: end-of-year snapshots are encoded as Jan 1 of the following year (e.g. simulation year 2015 → 2016-01-01), not Dec 31. Flux variable (FL) encoding is unchanged: mid-year timestamp Jul 1 with time bounds [Jan 1, Jan 1 next year]. experiments_ismip7.csv is redesigned to store nominal simulation years (start_year_min, start_year_max, end_year) instead of raw date strings. The checker derives expected FL/ST timestamps at runtime via the new _nominal_to_timestamp() helper, applying ±1 day tolerance for float32 encoding jitter. _check_naming() and _check_time() both receive var_type so the ST year offset (filename year N = timestamp year N+1) is handled correctly. The test suite and README are updated accordingly.
The variable request criteria are now stored in conventions/ISMIP7_variable_request.csv instead of an Excel file, making the data diff-friendly and human-readable in version control. Both compliance_checker.py and generate/generate_test_files.py are updated to use pd.read_csv(); openpyxl is removed from isschecker_env.yml. README, generate/README, and CLAUDE.md are updated to reflect the new file name and dropped dependency.
Member
Author
|
Validated to reproduce the same results as with csv compared to the excel conventions file. Adjusted ranges should make the checker less sensitive for some models. Moving forward with this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The variable request criteria are now stored in conventions/ISMIP7_variable_request.csv instead of an Excel file, making the data diff-friendly and human-readable in version control. Both compliance_checker.py and generate/generate_test_files.py are updated to use pd.read_csv(); openpyxl is removed from isschecker_env.yml. README, generate/README