Skip to content

Fix bounds on several fields#7

Open
xylar wants to merge 3 commits into
ismip:mainfrom
xylar:fix-bounds
Open

Fix bounds on several fields#7
xylar wants to merge 3 commits into
ismip:mainfrom
xylar:fix-bounds

Conversation

@xylar

@xylar xylar commented Jun 30, 2026

Copy link
Copy Markdown
Member

Antarctic max elevation is ~5000 m, so give it some buffer.

Grounding line flux can occasionally go negative (e.g. at ice rises) so allow a small, negative flux.

Antarctic max elevation is ~5000 m, so give it some buffer.

Grounding line flux can occasionally go negative (e.g. at ice rises)
so allow a small, negative flux.
@xylar xylar requested a review from hgoelzer June 30, 2026 08:21
@xylar

xylar commented Jun 30, 2026

Copy link
Copy Markdown
Member Author

@hgoelzer, let me know what you think of these changes. Feel free to suggest alternatives.

@hgoelzer

Copy link
Copy Markdown
Member

Hi Xylar, here are a few more bounds problems reported by ISM_BERN we should address at the same time. Can you add those please?

  • acabf variable, our minimum value in the simulation (-0.0004506820987444371) is out of range based on the file checker. Min value accepted: -0.0001: we think this our value is resulting from the climatic mass balance variable from the CESM2-WCCM ssp585 forcings. We checked the value of the SMB that our ISM reads as an input from the PISM ISMIP6 surface forcing scheme: in the last year of the future simulation it is lower than the lower accepted limit of -0.0001 kg m-2 s-1.

  • libmassbfgr variabole, max value is out of range. Max value accepted: 0.0: same as in the historical simulation.

  • strbasemag variable, max value (8963770.0) is out of range. Max value accepted: 300000.0: same as in the historical simulation.

  • xvelmean variable, max value (0.0005406480049714446) is out of range. Max value accepted: 0.0004: same as in the historical simulation.

@hgoelzer hgoelzer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comment in conversations with additional bounds

@xylar

xylar commented Jun 30, 2026

Copy link
Copy Markdown
Member Author

@hgoelzer, I'm seeing:
https://github.com/ismip/ISM_SimulationChecker/blob/main/conventions/ISMIP7_variable_request.csv#L7
so it looks like acabf has already been addressed?

For the others, I'm happy to adjust but please let me know what you want the new bounds to be.

@xylar

xylar commented Jun 30, 2026

Copy link
Copy Markdown
Member Author

@xylar

xylar commented Jun 30, 2026

Copy link
Copy Markdown
Member Author

I made my best guesses with strbasemag, xvelmean and yvelmean. It doesn't look to me like acabf and libmassbfgr need further updates, but let me know.

@xylar xylar requested a review from hgoelzer June 30, 2026 09:08
@xylar xylar changed the title Fix bounds on lithk, orog, topg and ligroundf Fix bounds on several fields Jul 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants