Skip to content

Name the author j127 instead of J - #10

Merged
j127 merged 2 commits into
mainfrom
claude/sessionpad-mod-865578
Oct 30, 2026
Merged

j127 merged 2 commits into
mainfrom
claude/sessionpad-mod-865578

Conversation

@j127

@j127 j127 commented Oct 30, 2026 •

Copy link
Copy Markdown
Owner

The owner asked for the mod's author to read j127, the GitHub account it is published from, instead of J.

What changes

  • author.name in the plugin manifest, plugin.json: J → j127.
  • owner.name in the marketplace file, marketplace.json: J → j127.
  • The byline in PRIVACY.md ("made by j127").
  • The copyright line in both LICENSE files (the root one and the copy in the plugin folder), at the owner's word: J → j127.
  • A CHANGELOG line under 0.4.0.
  • Tests in scripts/listing.test.ts that both names are the repository's account, and that the two licenses match and name j127. Putting J back in the author, the owner or either license fails a test; the privacy page's byline and the CHANGELOG aren't tested.

The author name is display metadata. Installs and updates go by the plugin's name, sessionpad, which is unchanged, so existing installs aren't affected.

How it was checked

just check passes: formatting, strict validation of the mod and the marketplace, the type check, dollar_check, 29 script tests and 366 mod tests.

Review

A reviewer subagent with fresh context read 27a4507 and found nothing to fix. The license change came after it, in 9ee6ae1. A second reviewer with fresh context read 9ee6ae1: both licenses differ from the MIT text only in line 3 and are identical, and the test holds them to j127. It found two inaccuracies in this description, both now fixed: it said a test covers every place J was changed (it covers four), and it ticked the review below before that commit had one.

  • Both manifests parse and validate in strict mode.
  • The new test passes, and it fails when either name goes back to J.
  • The commit message and the PR text follow the repository's rules.

Its only questions were about a sample note in the design mockups under mockups/, "Ask J for the two README screenshots.". That's made-up pane content in files that don't ship with the plugin, not the author field, so it stays as it is.

Before merging

  • A reviewer with fresh context reads the diff (above), and its findings are fixed.
  • CI green.
  • The owner's OK to merge into main.

plugin.json's author, the marketplace's owner and the privacy policy's
byline said J. They now say j127, the GitHub account that publishes the
mod. The name is display metadata only: installs and updates go by the
plugin's name, which is unchanged. A test holds both manifests to the
repository's account. The LICENSE files' copyright line still says J.
@j127
j127 marked this pull request as ready for review October 30, 2026 01:23
At the owner's word, the copyright line in LICENSE and in the copy that
ships in sessionpad/ says j127, like the author and the marketplace
owner. A test holds the two copies to the same text and that holder.
@j127
j127 merged commit a5b1ea9 into main Oct 30, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant