Repository navigation
Name the author j127 instead of J - #10
Merged
Merged
Conversation
plugin.json's author, the marketplace's owner and the privacy policy's byline said J. They now say j127, the GitHub account that publishes the mod. The name is display metadata only: installs and updates go by the plugin's name, which is unchanged. A test holds both manifests to the repository's account. The LICENSE files' copyright line still says J.
j127
marked this pull request as ready for review
October 30, 2026 01:23
At the owner's word, the copyright line in LICENSE and in the copy that ships in sessionpad/ says j127, like the author and the marketplace owner. A test holds the two copies to the same text and that holder.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The owner asked for the mod's author to read
j127, the GitHub account it is published from, instead ofJ.What changes
author.namein the plugin manifest,plugin.json:J→j127.owner.namein the marketplace file,marketplace.json:J→j127.PRIVACY.md("made by j127").LICENSEfiles (the root one and the copy in the plugin folder), at the owner's word:J→j127.scripts/listing.test.tsthat both names are the repository's account, and that the two licenses match and namej127. PuttingJback in the author, the owner or either license fails a test; the privacy page's byline and the CHANGELOG aren't tested.The author name is display metadata. Installs and updates go by the plugin's
name,sessionpad, which is unchanged, so existing installs aren't affected.How it was checked
just checkpasses: formatting, strict validation of the mod and the marketplace, the type check,dollar_check, 29 script tests and 366 mod tests.Review
A reviewer subagent with fresh context read
27a4507and found nothing to fix. The license change came after it, in9ee6ae1. A second reviewer with fresh context read9ee6ae1: both licenses differ from the MIT text only in line 3 and are identical, and the test holds them toj127. It found two inaccuracies in this description, both now fixed: it said a test covers every placeJwas changed (it covers four), and it ticked the review below before that commit had one.J.Its only questions were about a sample note in the design mockups under
mockups/, "Ask J for the two README screenshots.". That's made-up pane content in files that don't ship with the plugin, not the author field, so it stays as it is.Before merging
main.