Repository navigation
Answer the directory's review warnings where the code can - #11
Merged
Merged
Conversation
The plugin directory's check of 0.4.0 listed warnings against the hooks module and the manifest. This addresses the ones the code can: - The four git commands are each written out whole as fixed text in ioOf (run.git takes a GitCommand name), so the directory reads exactly what runs instead of "git" with variable arguments. Same commands as before. - plugin.json drops `types`, which the directory reported as an unrecognized field; the contract sits at the default path that the minimum supported release finds on its own, and strict validation still checks every state key against it. - The plugin README answers the remaining findings in their own terms: the exact git commands, no build, start-up, settings or instructions file written of the mod's own accord, no tool but its own two answered in place of the tool, what the command and session-start hooks do, and that the summary call is the only request the mod makes itself. Version 0.4.1, not released yet.
The review found two of the new README sentences untrue of the code. The session-start hook for /clear, /resume and /branch does more than reload the pad: it carries the pad and the timeline on /clear and /branch, drops unsaved typing in the pane and refreshes the Workspace tab, while still passing the event on unchanged. And inside its folders the mod also writes the exports you ask for and a copy of a timeline it finds unreadable. Both sentences now say so. The git.ts header names the four fixed calls, and the git switch gets a never-typed default, so a command name added without its case fails to type-check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The directory's check of 0.4.0 stopped it as "Plugin not fully checked" and listed warnings against the hooks module and the manifest. The stop itself names no finding to fix: it asks for a new check, which a new commit on
mainstarts. This PR answers the warnings the code can answer, so that new check has less to flag.What changes
$.process.run(["git", ...args], init).run.gitnow takes a command name (top-level,branch,short-sha,worktrees), andioOfruns each as fixed text:git rev-parse --show-toplevel,git symbolic-ref --short -q HEAD,git rev-parse --short HEADandgit worktree list --porcelain. They are the same commands as before.typesdropped fromplugin.json. The directory listed it as an unrecognized field. The contract is at the default path,types/index.d.ts, which the minimum supported release (2.1.299) finds without the field. Strict validation still checks every state key against it. The other three unrecognized fields are the listing links, which the finding itself says to keep./clear,/resumeand/branch) passes the event on unchanged, and the README says what it does besides;What stays a warning
These describe what the mod does by design, so a reviewer reads them rather than the code changing:
duandrmon paths;The README already discloses each one.
How it was checked
just checkpasses: formatting, strict validation, the type check,dollar_check, 29 script tests and 367 mod tests, one of them new (each named git command runs exactly its argv). Validation with the directory profile passes.Review
A reviewer subagent with fresh context read
14ad245. It found the code change correct:src/git.tsran before;src/git.tsis the only caller;types.It asked for two README fixes before merging. What it found, and what changed in
fca1a9f:/clearand/branchit carries the pad and the timeline to the new session. It also loads that session's pad, drops unsaved typing in the pane, and refreshes the Workspace tab. The README now says all of that, and that the hook still passes the event on unchanged.src/git.ts's header comment now names the four fixed calls. It was edited, not removed.never-typed default, so a command name added without its case fails to type-check. Adding a fifth name was tried, and the type check failed.Before merging
main.