Repository navigation
Drop the directory install route from the READMEs - #12
Merged
Merged
Conversation
The plugin directory takes mods only from verified organizations, so Session Pad won't be listed there and the submission is withdrawn. The plugin README no longer describes installing it from the directory; it installs from the author's marketplace. The root README stops calling PRIVACY.md and the license the listing's links. Both files stay, and so do the listing fields in plugin.json.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The plugin directory refused 0.4.1: it accepts mods, and code files of any kind, only from verified organizations. The owner is withdrawing the submission, so the READMEs shouldn't describe a directory install.
What changes
sessionpad/README.md, the one that ships with the mod): the paragraph about adding Session Pad from the plugin directory (assessionpad@synced) is gone. The install section now says the mod installs from the author's marketplace, with the same commands as before.PRIVACY.mdand the license are no longer described as the listing's links. Both files stay, as the privacy policy and the terms of use.Kept as they are:
plugin.json(privacy, terms, support), which nothing reads at load time and which still point at real pages.No version bump, since this is documentation only.
How it was checked
just checkpasses: formatting, strict validation, the type check,dollar_check, 29 script tests and 367 mod tests.Review
A reviewer subagent with fresh context read
c1246edand found nothing that blocks a merge:Its one note was optional. The plugin README's sentence on the plugin's id ("
sessionpad@sessionpadwhen it came from the author's marketplace") dates from when there were two routes. It stays as it is: it's still accurate, since a copy loaded from a folder shows a different id.Before merging
main.