Repository navigation
Meet the plugin directory's rules for mod code - #6
Merged
Merged
Conversation
The directory's validation blocked the submission on two rules: - It accepts no settings call from a mod that keeps its engine for later, as every button and timer here does. The Timeline tab's Turn on summaries button called $.config.set; the offer now says how to turn summary lines on (set summaryModel to haiku) and has a Got it button that dismisses it. The config.set hook and the summary setting the module kept are gone too: a change in /config reloads the mod with the new value, so the setting is now a plain value read at load. - It reads $ only as $.noun.method(...) calls, whole. $.plugin.name, a property, becomes the mod's fixed name, and a $.fs.stat call that Prettier split across lines is kept on one line. The plugin README now also says the mod changes no settings, that the summary call goes through Claude Code's own model access and the mod reads no credential, what its hooks answer, and that /pad-export never replaces a file that isn't an earlier export. Version 0.4.0.
- The Timeline card and the plugin README no longer send the person to each other: the README's Settings section has the shell command, with how to find the plugin's id, and the card points to it. - Tests cover the offer after /clear both with summaries off and on, so a wrong value passed to refreshOffer there now fails a test. - Command ownership is tested with real marketplace ids, and against a plugin whose name only starts the same. - just check gains dollar_check, which fails when a call on $ is split across lines or a property of $ is read, as the directory's rule needs. - The CHANGELOG entry drops a stray "as before".
The directory's details for the three unreadable uses of $ named the calls in noteCommand, headlineCommand and exportCommand: functions in the hook file that took $ with other arguments and passed it on to another file's function. It reads $ passed on only from a hook's own body, or from a function in the hook file that takes $ alone. So the three commands now do their work in their hooks, as the note tool always has, and refreshOffer takes $ alone again, reading whether summary lines are off from a module variable that register sets.
j127
marked this pull request as ready for review
October 29, 2026 20:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sessionpad 0.4.0: the changes the plugin directory's validation asked for. The owner's first validation in the developer portal found 4 blocking findings, 3 warnings and 12 policy holds.
Blocking findings
A settings call from a mod that keeps its engine for later (
src/ui.tsx). The Turn on summaries button called$.config.set, and the directory accepts no settings call from a mod that keeps its engine past a hook, as every button and timer in this mod does. Fixed by removing the call:summaryModeltohaiku), with a Got it button that dismisses it for every session;config.sethook and the summary setting the module kept are gone. A change in/configreloads the mod with the new value, so the setting is read once, at load;Three uses of
$the directory couldn't read. The expanded findings namedhooks/register.tslines 290, 304 and 315 onmain: the calls innoteCommand,headlineCommandandexportCommand. These were functions in the hook file that took$along with other arguments and passed it on to another file's function. The directory reads$passed on only from a hook's own body, or from a function in the hook file that takes$alone. In9ed23a4:refreshOffer, which this branch had given a second argument, takes$alone again.Earlier, in
512c109, two likely troublemakers were fixed too:$.plugin.name(a property read) became the mod's fixed name, and a$.fs.stat(...)call that Prettier had split across lines was kept on one line.Policy holds and notes
The plugin README now says:
/pad-exportnever replaces a file that isn't an earlier export.The other holds (a name close to another listing;
git,duandrmwith paths; the export writing a file) are for a reviewer, and the README already discloses each. Thetypesfield stays: the app ignores it at load, but the local validator reads the$.statecontract from it.Tests
The offer tests are rewritten for the new card: shown while summaries are off, the instructions, Got it across sessions and a full store, and an answer from another session. The tests for the removed settings call are gone with it. The suite is 360 tests.
Review
A reviewer subagent with fresh context read
512c109. It found nothing critical, and confirmed that every remaining use of$is a whole$.noun.method(call on one line, passed only to top-level function declarations. What it found, and what changed in64a21de:refreshOfferafter/clearfailed no test. Two tests now cover the offer after/clearwith summaries off and on, and each flip fails a test.@inline,@sessionpad,@synced) and against a plugin whose name only starts the same; a newdollar_checkrecipe injust checkfails if a call on$is ever split across lines or a property of$is read; and a stray "as before" in the CHANGELOG is gone.Before merging
64a21deand9ed23a4and approved them. Its minor points (a stricterdollar_checkthat ignores trailing comments and catches grep errors, and a comment that should mention closures) come with the next round of portal findings.main.