Improve folder sharing and ZIP downloads - #124
Conversation
Co-authored-by: Radhey Kalra <radheykalra901@gmail.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Co-authored-by: Radhey Kalra <radheykalra901@gmail.com>
Co-authored-by: Radhey Kalra <radheykalra901@gmail.com>
Co-authored-by: Radhey Kalra <radheykalra901@gmail.com>
Co-authored-by: Radhey Kalra <radheykalra901@gmail.com>
| Upload: p.Upload, | ||
| Delete: p.Delete, | ||
| CanReplace: p.Delete || p.LegacyReplace, | ||
| Write: p.Delete || p.LegacyReplace, |
There was a problem hiding this comment.
Upload links appear read-only A modern upload-only folder link returns
upload: true but write: false. The previous public share page checks write before showing Add files, so recipients using that client cannot upload through a link that allows it. Keep the legacy write field aligned with upload access; canReplace already reports replacement access.
| Write: p.Delete || p.LegacyReplace, | |
| Write: p.Upload, |
Knowledge Base Used: File sharing
Co-authored-by: Radhey Kalra <radheykalra901@gmail.com>
|
@coderabbitai full review |
What changed
write-link replacement behavior without granting replacement to modern upload-only links.Screenshots
The Settings image shows disposable test links; those links were revoked after verification.
Verification
cd backend && go test ./...cd frontend && pnpm run checkcd frontend && pnpm run lintcd frontend && pnpm run build(passes; Vite reports the existing large-chunk warning)The PR is not yet safe to merge because older public clients cannot upload through modern upload-only links.
Findings
Summary
The PR adds folder-share permission modes and upload caps, owner-side link management, and ZIP downloads for private and public folders. The follow-up changes preserve limits on permissions-only updates, address the previously reported symlink deletion and archive-route issues, and add ZIP name disambiguation.
Diagram
%%{init: {'theme': 'neutral'}}%% flowchart LR Owner[Owner] --> Shares[Create or manage share] Shares --> Token[Public token] Token --> Access{Permissions} Access --> Browse[Browse and download] Access --> Upload[Upload with per-link cap] Access --> Delete[Delete or replace] Browse --> ZIP[Bounded folder ZIP]Reviews (2) · Last reviewed commit: "Align share API examples with legacy ali..."