Repository navigation
FEATURE: Add ZooKeeper discovery and cache node watching - #2
Merged
Merged
Conversation
f1v3-dev
force-pushed
the
feature/apl-161
branch
3 times, most recently
from
October 21, 2026 04:54
68ba8f8 to
fc11f40
Compare
ing-eoking
reviewed
Oct 21, 2026
f1v3-dev
force-pushed
the
feature/apl-161
branch
from
October 21, 2026 07:50
fc11f40 to
b163fbb
Compare
ing-eoking
reviewed
Oct 21, 2026
Comment on lines
+19
to
+23
| if not host or not 1 <= int(port or 0) <= 65535: | ||
| logger.warning( | ||
| f"Ignoring invalid cache node {child}", | ||
| ) | ||
| continue |
Collaborator
There was a problem hiding this comment.
host, _, port = address.rpartition(":")
try:
if not host or not (1 <= int(port) <= 65535):
raise ValueError
addresses.add(address)
except ValueError:
logger.warning(f"Ignoring invalid cache node {child}")
continue
Collaborator
Author
There was a problem hiding this comment.
host, _, port = address.rpartition(":")
if (
not host
or not port
or not port.isascii()
or not port.isdecimal()
or not 1 <= int(port) <= 65535
):
logger.warning(f"Ignoring invalid cache node {child}")
continue
addresses.add(address)위와 같은 형태가 더 낫다고 판단하여 수정하였습니다.
f1v3-dev
force-pushed
the
feature/apl-161
branch
from
October 21, 2026 08:05
b163fbb to
8df3487
Compare
f1v3-dev
force-pushed
the
feature/apl-161
branch
from
October 21, 2026 08:07
8df3487 to
b2ec2a5
Compare
ing-eoking
approved these changes
Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Related Issue
⌨️ What I did
ArcusDiscovery를 구현합니다.