Repository navigation
INTERNAL: Build the crate as a cdylib with project lints #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,54 @@ | ||
| [package] | ||
| name = "arcus-vector" | ||
| description = "Vector search for arcus-memcached, loaded as an ASCII protocol extension (-X)" | ||
| version = "0.1.0" | ||
| edition = "2024" | ||
| # let-chains (`if let .. && let ..`). | ||
| rust-version = "1.88" | ||
| publish = false | ||
|
|
||
| [dependencies] | ||
| [lib] | ||
| # memcached loads the module as `libarcusv.so` with `-X`. | ||
| name = "arcusv" | ||
| crate-type = ["cdylib"] | ||
|
|
||
| [lints.rust] | ||
| unsafe_op_in_unsafe_fn = "deny" | ||
| unused_qualifications = "warn" | ||
| rust_2018_idioms = { level = "warn", priority = -1 } | ||
| trivial_numeric_casts = "warn" | ||
| unused_import_braces = "warn" | ||
|
|
||
| [lints.clippy] | ||
| # Raw pointers change type with `.cast()`/`.cast_mut()`, not `as`. | ||
| ptr_as_ptr = "warn" | ||
| ptr_cast_constness = "warn" | ||
| borrow_as_ptr = "warn" | ||
| # Lossless conversions use `From`, so an `as` cast marks one that can lose. | ||
| cast_lossless = "warn" | ||
| manual_let_else = "warn" | ||
| semicolon_if_nothing_returned = "warn" | ||
| redundant_closure_for_method_calls = "warn" | ||
| cast_ptr_alignment = "warn" | ||
| # A daemon module must not panic on a code path a request can reach; tests may. | ||
| # `clippy.toml` lets tests unwrap. | ||
| unwrap_used = "warn" | ||
| expect_used = "warn" | ||
| # Messages go through the server's logger, which honours `-v` and logger extensions; | ||
| # printing directly bypasses both. | ||
| print_stderr = "warn" | ||
| print_stdout = "warn" | ||
| # Every `unsafe` block says why it is sound, next to it. | ||
| undocumented_unsafe_blocks = "warn" | ||
| unnecessary_safety_comment = "warn" | ||
| # A lint is silenced with `#[expect(.., reason = "..")]`: the reason stays with the code, and | ||
| # the compiler says when the exception is no longer needed. | ||
| allow_attributes = "warn" | ||
| allow_attributes_without_reason = "warn" | ||
| # Leaks are deliberate here (never free under the cache lock); each one says so. | ||
| mem_forget = "warn" | ||
| dbg_macro = "warn" | ||
| todo = "warn" | ||
| unimplemented = "warn" | ||
| use_self = "warn" | ||
| or_fun_call = "warn" | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| # Lets tests unwrap and print; the module itself may not (`Cargo.toml` [lints]). | ||
| allow-unwrap-in-tests = true | ||
| allow-expect-in-tests = true | ||
| allow-print-in-tests = true |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| edition = "2024" | ||
| style_edition = "2024" |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.