Repository navigation
Use the configured Catch2 headers in tests - #18
Closed
james-d-mitchell wants to merge 1 commit into
Closed
james-d-mitchell wants to merge 1 commit into
james-d-mitchell wants to merge 1 commit into
Conversation
Remove direct includes of the bundled Catch2 3.14.0 header from the Knuth-Bendix, matrix, and rewriting-system tests. test-main.hpp already selects the configured bundled or external Catch2 header. This fixes the missing Catch::ITransientExpression typeinfo when these tests are linked against external Catch2 3.16.1. AI assistance: OpenAI Codex diagnosed the CI failure, prepared the fix, ran validation, and wrote the commit message and PR description. Co-authored-by: Codex <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The external-Catch2 CI jobs fail when tests include the bundled Catch2 3.14.0 header but link against Catch2 3.16.1, which changed
Catch::ITransientExpression. Remove the direct bundled-header includes from all 14 affected test files and use their existingtest-main.hppinclude to select the configured Catch2 headers. No dependency versions are pinned.This addresses the CI failure observed on libsemigroups#1105.
Validation:
test_knuth_bendix,test_matrix, andtest_rewriting_systemwithmake -j6, using both bundled Catch2 3.14.0 and external Catch2 3.16.1.[quick]: 597 test cases and 4,363 assertions passed in each configuration.pre-commit run --hook-stage pre-push --files <changed files>andgit diff --check: passed.AI assistance: OpenAI Codex diagnosed the failure, prepared the fix, ran validation, and wrote the commit message and PR description. The commit includes Codex as a co-author.