1002-units-06 - CI check - #11
Open
jamillambert wants to merge 5 commits into
Open
jamillambert wants to merge 5 commits into
jamillambert wants to merge 5 commits into
Conversation
`Target` and `Work` were moved into `units` but the API tests were not updated to cover them. `CommonTraits` is also missing `Sequence`. Add the missing types to the struct lists and the export checks. Assisted-by: Claude Opus 5.5
Several public error types are not in the `Errors` struct, so the API tests do not check their derives, `Send`, `Sync` or `Display`. The `CompactTargetDecoderError` is in `Errors` even though decoder errors are meant to be in `DecoderErrors`. Add the missing error types and move the decoder error. Assisted-by: Claude Opus 5.5
`c_serde` only checks some of the types that implement the serde traits. Add the remaining locktime, time and pow types. Assisted-by: Claude Opus 5.5
Decoder errors are listed in `DecoderErrors`, but `c_send_sync` only checks the general error aggregate, `Decoders` is not checked at all and `c_good_err_display` only covers one decoder error. Check `Send` and `Sync` for all decoders and decoder errors, and `Display` for all decoder errors, when encoding is enabled. Assisted-by: Claude Opus 5.5
No API test checks that the public error types implement `std::error::Error`, so a missing impl would go unnoticed. Add a test that checks every public error type when std is enabled. Assisted-by: Claude Opus 5.5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI check only