memcache - chore: defense - stage npm releases from CI - #117
Merged
Conversation
Pack a tarball and run pnpm stage publish so CI can only stage; a maintainer still has to promote. Reconcile zizmor items as merged in PR #116. Co-authored-by: Jared Wray <me@jaredwray.com>
Co-authored-by: Jared Wray <me@jaredwray.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #117 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 8 8
Lines 1399 1399
Branches 303 308 +5
=========================================
Hits 1399 1399 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Switch the release workflow from live
pnpm publishto pack +pnpm stage publish, so CI can only stage an artifact.Status update
DEFENSE_IN_DEPTH.md: § 5 stage publish → (PR #117 pending); § 4 zizmor / persist-credentials / publish-job cache disable → PR #116 (merged)Changes
release.yamlpublish job:pnpm pack --pack-destination packedthenpnpm stage publish ./packed/*.tgz --access public --provenance --no-git-checksSECURITY.mdnpmjs.com still needs the trusted publisher set to stage-only (manual). Drydock and 2FA promotion are also manual.
Verification
zizmor .github/workflows/release.yaml— no findingsReference
defense-in-depth-nodejs § 5