Conversation
|
Because this is a change in error handling behavior, this will require an opt-in flag. The new flag will require documentation. Yes, unit tests are mandatory for all changes, even to existing logic. Finally, add the changelog entry following the same pattern used by all other changelog entries. |
|
Ty for the feedback! I've added the requirements, the opt-in flag is I also reduced log size when it lists shards because for example a cluster with 200 indices with 5 shards each gonna print 1000 shards in one line, maybe we want to handle it another way though? Lmk if I have to change something else |
|
Your changes are looking good. Please add the new param to schema.yaml. |
Description
Elastalert would raise an error if a shard is unavailable from the query, this means an old index out of the time range of the query is red, and recent onces are green and therefore query would work, it would simply skip.
This means that any degraded cluster might not be able to have rules to work.
This forces the query to be run even if some shards are unavailable.
Checklist
make test-dockerwith my changes.Questions or Comments
Let me know if you need additional information or I must change something.