Rteco alpine#3561
Open
naveenku-jfrog wants to merge 33 commits into
Open
Conversation
7af2722 to
ac81485
Compare
18c3b05 to
89e6093
Compare
89e6093 to
7177b09
Compare
7177b09 to
bcfba32
Compare
ee511cf to
dcc6d06
Compare
Register jf apk / jf apk config / jf apk upload in jfrog-cli and update module dependencies to pick up the new Alpine implementation: - buildtools/cli.go: Add ApkCmd dispatcher with subcommand routing for config, upload, and native apk passthrough; extract --server-id, --repo, --alpine-version, --user, --password, --branch, --arch, --apply from args; builder-pattern construction of ApkCommand / ApkConfigCommand / ApkUploadCommand - docs/buildtools/apkcommand/help.go: Usage, description, and argument reference strings for jf apk --help - utils/cliutils/commandsflags.go: Add Apk constant, apkAlpineVersion / apkArch flag definitions, and Apk command flag list - go.mod: Upgrade jfrog-cli-artifactory to v0.8.1-0.20260621212942-c4258681e69a and build-info-go to v1.13.1-0.20260621212604-330cfe272ba6 Co-authored-by: Cursor <cursoragent@cursor.com>
…gFromArgs Co-authored-by: Cursor <cursoragent@cursor.com>
7f9c899 to
213f8f6
Compare
Add "apk" to SupportedTools so that when JFROG_CLI_GHOST_FROG=true and the apk binary is symlinked to jf, invoking `apk add ...` is transparently intercepted and rewritten to `jf apk add ...`. Co-authored-by: Cursor <cursoragent@cursor.com>
29 e2e tests covering all jf apk subcommands: add, upgrade, del, update, info, search, fetch, fix, audit, version, stats, config, and upload. Tests validate build-info structure, dependency ID format, prod/transitive scopes, requestedBy chains, checksums, module override, multiple-build isolation, JF flag stripping, Ghost Frog wiring, env secret filtering, and the --alpine-version flag. The TestApk flag and Alpine repo infrastructure (constants, repo templates, main_test.go wiring) are in the prerequisite CI PR so that the workflow can compile cleanly before this file is present. Co-authored-by: Cursor <cursoragent@cursor.com>
0214c4f to
98397ae
Compare
Address PR #3590 review: rename test flag and build-name constant to use 'Alpine' prefix for consistency with AlpineLocalRepo/RemoteRepo/VirtualRepo. Also update skip message to reference '-test.alpine=true'. Co-authored-by: Cursor <cursoragent@cursor.com>
* Remove redundant functions in agent namespace * Update go.mod # Conflicts: # go.mod # go.sum
Bumps [github.com/containerd/containerd](https://github.com/containerd/containerd) from 1.7.32 to 1.7.33. - [Release notes](https://github.com/containerd/containerd/releases) - [Changelog](https://github.com/containerd/containerd/blob/main/RELEASES.md) - [Commits](containerd/containerd@v1.7.32...v1.7.33) --- updated-dependencies: - dependency-name: github.com/containerd/containerd dependency-version: 1.7.33 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Remove redundant functions in agent namespace * Update go.mod and go.sum file
* JGC-476 - Fix ghost frog install to honour default ModePass tools * JGC-476 - Fix ghost frog workflow upload path and setup version mismatch
Co-authored-by: IL-Automation <eco-system@jfrog.com>
Extend ShouldHideSurveyLink to also check ExecutionContext.IsAgent from jfrog-cli-core, so the post-help survey prompt isn't shown when jfrog-cli is invoked by an AI coding agent (Claude Code, Cursor, Gemini CLI, etc.). Also clear agent-detector env vars in existing survey tests so they stay deterministic when run from within an agent shell.
* RTECO-945 - Add CI workflow to run Alpine APK tests
Register jf apk / jf apk config / jf apk upload in jfrog-cli and update module dependencies to pick up the new Alpine implementation: - buildtools/cli.go: Add ApkCmd dispatcher with subcommand routing for config, upload, and native apk passthrough; extract --server-id, --repo, --alpine-version, --user, --password, --branch, --arch, --apply from args; builder-pattern construction of ApkCommand / ApkConfigCommand / ApkUploadCommand - docs/buildtools/apkcommand/help.go: Usage, description, and argument reference strings for jf apk --help - utils/cliutils/commandsflags.go: Add Apk constant, apkAlpineVersion / apkArch flag definitions, and Apk command flag list - go.mod: Upgrade jfrog-cli-artifactory to v0.8.1-0.20260621212942-c4258681e69a and build-info-go to v1.13.1-0.20260621212604-330cfe272ba6 # Conflicts: # go.mod # go.sum
Contributor
|
I have read the CLA Document and I hereby sign the CLA 5 out of 6 committers have signed the CLA. |
Contributor
…i.go - errcheck: replace defer os.RemoveAll with clientTestUtils.RemoveAllAndAssert so the error return is not silently dropped (apk_test.go lines 658, 761) - ineffassign: reassigned args is never read after ExtractBoolFlagFromArgs; use _ to make the intent explicit (buildtools/cli.go line 2215) Co-authored-by: Cursor <cursoragent@cursor.com>
# Conflicts: # go.mod # go.sum
Co-authored-by: IL-Automation <eco-system@jfrog.com>
- Add docs/api-spec/stub/ with 10 trimmed real operations (Access users/groups/permissions/tokens/roles, Artifactory system, Workers) extracted from JFrog's platform API reference - Add the apispec package (docs/api-spec/) that lazily parses the embedded OpenAPI YAML once per process; ships a stub bundle by default and a full bundle behind the "full" build tag - Add Makefile stub/full targets and a JF_BUILD_TAGS passthrough in build/build.sh for the internal release pipeline to opt into the full bundle
Ghost Frog behaviour is already comprehensively covered by the dedicated ghostfrog_test.go suite (47 tests covering install, dispatch, kill-switch, recursion-prevention, passthrough, and more). The per-package-manager smoke test in apk_test.go adds no new coverage and is removed. Co-authored-by: Cursor <cursoragent@cursor.com>
Replace TestApkUpdate_Passthrough, TestApkUpdate_PassthroughWithBuildFlags, TestApkDel_Passthrough, TestApkInfo_Passthrough, TestApkSearch_Passthrough, TestApkFetch_Passthrough, TestApkFix_Passthrough, TestApkAudit_Passthrough, TestApkVersion_Passthrough, and TestApkStats_Passthrough with a single TestApkPassthroughCommands table-driven test. Same coverage, far less boilerplate. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

masterbranch.go vet ./....go fmt ./....