Skip to content

Support ppxlib 0.37 + 0.38 - #49

Merged
jmid merged 9 commits into
mainfrom
support-ppxlib-0.37
Sep 14, 2026
Merged

jmid merged 9 commits into
mainfrom
support-ppxlib-0.37

Conversation

@jmid

@jmid jmid commented Sep 10, 2026

Copy link
Copy Markdown
Owner

This updates the preprocessor to be compatible with ppxlib 0.37 + 0.38.
The AST changes around function nodes means that this won't build with an earlier version, so I've made 0.37 the lower bound.

I've also updated the dune-bound to require at least 3.22.0

  • as that was the version requirement added in Adjust dune bound #48
  • stating a duplicate bound with a dune-generated opam-file requires at least 3.22.0 to state (warnings (duplicate_deps disabled))

I've checked locally that this now builds on 5.5 and 5.4.
The test suite cram tests fail there though due to printing differences, so I've added a with-test upper bound for now.

@jmid

jmid commented Sep 10, 2026

Copy link
Copy Markdown
Owner Author

After adding an ocaml < 5.3 upper bound for with-test it is now failing on 5.2 😬

@jmid

jmid commented Sep 14, 2026

Copy link
Copy Markdown
Owner Author

CI fails on

  • GHA 5.3.x - since the CI is setup to do so (fixed in next PR)
  • 4.14.x ppc64 and FreeBSD - like the previous PRs

@jmid
jmid merged commit 1cc1491 into main Sep 14, 2026
8 of 13 checks passed
@jmid
jmid deleted the support-ppxlib-0.37 branch September 14, 2026 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant